Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to developer manual #17307

Closed
jdemeyer opened this issue Nov 8, 2014 · 13 comments
Closed

Minor fixes to developer manual #17307

jdemeyer opened this issue Nov 8, 2014 · 13 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Nov 8, 2014

Continue the process of reorganization started in #17112 and continued in #17255.

Component: documentation

Author: Karl-Dieter Crisman

Branch: a9e9911

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/17307

@jdemeyer jdemeyer added this to the sage-6.4 milestone Nov 8, 2014
@jdemeyer
Copy link
Author

jdemeyer commented Nov 8, 2014

Branch: u/jdemeyer/ticket/17307

@jdemeyer
Copy link
Author

jdemeyer commented Nov 8, 2014

New commits:

a9e9911More reorganization of developer guide

@jdemeyer
Copy link
Author

jdemeyer commented Nov 8, 2014

Commit: a9e9911

@kcrisman
Copy link
Member

kcrisman commented Nov 9, 2014

comment:4

It would have been helpful to keep the commit in my name, I guess... but at any rate s-m only contributed the instructions for sws2rst, so I'm removing that. Thanks for the review.

@kcrisman
Copy link
Member

kcrisman commented Nov 9, 2014

Changed author from sarah-marie belcastro, Karl-Dieter Crisman to Karl-Dieter Crisman

@jdemeyer
Copy link
Author

jdemeyer commented Nov 9, 2014

comment:5

Replying to @kcrisman:

It would have been helpful to keep the commit in my name, I guess...

Honestly, I don't know how to do that...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 9, 2014

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

7fa0de3More reorganization of developer guide

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 9, 2014

Changed commit from a9e9911 to 7fa0de3

@jdemeyer
Copy link
Author

jdemeyer commented Nov 9, 2014

comment:7

Replying to @kcrisman:

It would have been helpful to keep the commit in my name

Done using

git commit --amend --author "Karl-Dieter Crisman"

@vbraun
Copy link
Member

vbraun commented Nov 9, 2014

Changed branch from u/jdemeyer/ticket/17307 to 7fa0de3

@cheuberg
Copy link
Contributor

Changed branch from 7fa0de3 to a9e9911

@cheuberg
Copy link
Contributor

Changed commit from 7fa0de3 to none

@cheuberg
Copy link
Contributor

comment:10

The last commit has not been merged, see the discussion at sage-devel.
The last commit was "only" the change of the author of the commit, so I do not open a new ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants