New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take in the module OEIS the keyword 'dead' of sequences into account. #17330
Comments
Commit: |
Branch: u/moritz/ticket/17330 |
comment:1
Here is how this could be fixed (see git branch). When doctesting this, I noticed the another bug:
This is due to the fact that the keyword 'changed' is temporarily added, so this would go away after a while. I propose to change that example to a sequence that is not altered as often as the Fibonacci numbers (see commit) New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
You should put your full name in the "Authors" field. |
Author: Moritz Firsching |
comment:6
done |
comment:7
The patch provided does not do what is in the description. Namely the dead sequences are not ignored! I would add an explicit error message like
Possibly, you could add an option to get it even if it is dead
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:9
Better! |
Reviewer: Vincent Delecroix |
Changed reviewer from Vincent Delecroix to none |
comment:10
Perhaps throwing an error is too much? I just pushed a version where you have a warning.. |
Reviewer: Vincent Delecroix |
comment:11
yeap. this is fine. (I rewrote my name as a reviewer) |
Changed branch from u/moritz/ticket/17330 to |
OEIS functions should simply ignore sequences with the
keyword 'dead'. At least they should not attempt to return
terms of these sequences.
For example the sequence A000017 https://oeis.org/A000017
is 'dead', what means it has errors in the data and was
replaced by another version. It is policy of the OEIS to
keep such sequences so they can be found in the case they
are referenced in the literature.
As it is now oeis(17).first_terms(12) throws the TypeError:
You found a sign inconsistency, please contact OEIS
CC: @mo271
Component: misc
Keywords: OEIS
Author: Moritz Firsching
Branch/Commit:
d416ecc
Reviewer: Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/17330
The text was updated successfully, but these errors were encountered: