New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
visualize_structure for sparse matrices over GF(p) is broken #17341
Comments
comment:1
|
This comment has been minimized.
This comment has been minimized.
Author: Jeroen Demeyer |
This comment has been minimized.
This comment has been minimized.
Commit: |
comment:5
I can't even create a matrix with a dimension >=
So I can't test the second part of this. The first part looks good. |
comment:6
The transposed should work if you have sufficient memory:
|
comment:7
The changes make sense, but I'm still stuck trying to find an example that used to be broken and now works. I get something like this with or without the change:
|
Reviewer: John Palmieri |
comment:8
As I said before, the second batch of changes make sense, whether they have any immediate benefit or not. So let's merge them. |
Changed branch from u/jdemeyer/visualize_structure_for_sparse_matrices_over_gf_p__is_broken to |
Solution: remove this specialized implementation, since the general one from
Matrix
works just fine.In the generic
visualize_structure()
method, we changeint
->Py_ssize_t
to support matrices larger than 2^31.Component: linear algebra
Author: Jeroen Demeyer
Branch/Commit:
2110b6a
Reviewer: John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/17341
The text was updated successfully, but these errors were encountered: