Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of Sage library cython files are underlinked. #17342

Closed
jpflori opened this issue Nov 14, 2014 · 11 comments
Closed

A bunch of Sage library cython files are underlinked. #17342

jpflori opened this issue Nov 14, 2014 · 11 comments

Comments

@jpflori
Copy link

jpflori commented Nov 14, 2014

In particular, we need explicit linking at build time for Cygwin.

CC: @tscrim

Component: porting: Cygwin

Keywords: cygwin linking

Author: Jean-Pierre Flori

Branch: fbf812d

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/17342

@jpflori jpflori added this to the sage-6.4 milestone Nov 14, 2014
@jpflori jpflori changed the title A bunch of Sage library cython files need to be linked to gmp. A bunch of Sage library cython files are underlinked. Nov 14, 2014
@jpflori
Copy link
Author

jpflori commented Nov 14, 2014

New commits:

fbf812dSome Sage library files are underlinked.

@jpflori
Copy link
Author

jpflori commented Nov 14, 2014

Changed keywords from none to cygwin linking

@jpflori
Copy link
Author

jpflori commented Nov 14, 2014

Branch: u/jpflori/ticket/17342

@jpflori
Copy link
Author

jpflori commented Nov 14, 2014

Author: Jean-Pierre Flori

@jpflori
Copy link
Author

jpflori commented Nov 14, 2014

Commit: fbf812d

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link

comment:3

I didn't test on Cygwin, but at least the patch makes sense and doesn't break anything for me.

@vbraun
Copy link
Member

vbraun commented Nov 15, 2014

Changed branch from u/jpflori/ticket/17342 to fbf812d

@sagetrac-Stefan
Copy link
Mannequin

sagetrac-Stefan mannequin commented Dec 2, 2014

Changed commit from fbf812d to none

@sagetrac-Stefan
Copy link
Mannequin

sagetrac-Stefan mannequin commented Dec 2, 2014

comment:5

I notice some of the matroid extensions got gmp as extra library. How do I determine that this is necessary? The code runs fine on my computer with and without gmp, I think. Without a way to tell, I'll get it wrong on future extensions.

@jpflori
Copy link
Author

jpflori commented Dec 3, 2014

comment:6

I'd say:

  • either look in the source code for gmp function (here it is typically mpn_popcnt or mpn_copyi),
  • or run ldd | grep U on the built object files and look for symbols with gmp in it,
  • or try to compile it under a cery touchy platform as Cygwin :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants