Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projective point equality returns false positive for ComplexIntervalField #17429

Closed
bhutz opened this issue Dec 1, 2014 · 15 comments
Closed

Comments

@bhutz
Copy link

bhutz commented Dec 1, 2014

Projective equality is returning false positives for ComplexIntervalField points because it is doing a negative check not a positive check

R.<x>=PolynomialRing(QQ)
r=(x^2-x-3).polynomial(x).roots(ComplexIntervalField(),multiplicities=False)
P.<x,y>=ProjectiveSpace(ComplexIntervalField(),1)
P1=P(r[0],1)
H=End(P)
f = H([x^2-3*y^2,y^2])
Q1=f(P1)
Q1==P1, Q1[0]==P1[0]

This is likely an issue for both points and morphisms.

Depends on #17324

Component: algebraic geometry

Author: Ben Hutz

Branch/Commit: 6aa86f9

Reviewer: Grayson Jorgenson

Issue created by migration from https://trac.sagemath.org/ticket/17429

@bhutz bhutz added this to the sage-6.5 milestone Dec 1, 2014
@bhutz bhutz self-assigned this Dec 1, 2014
@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Dec 2, 2014

comment:1

(related to #17427)

@bhutz
Copy link
Author

bhutz commented Dec 2, 2014

Branch: u/bhutz/ticket/17429

@bhutz
Copy link
Author

bhutz commented Dec 2, 2014

New commits:

218c56b17324: fix eq and ne for affine and projective morphisms
a02a1e1Merge branch 'develop' of git://trac.sagemath.org/sage into ticket/17324
b20353c17429: make == a positive check for project points and morphisms

@bhutz
Copy link
Author

bhutz commented Dec 2, 2014

Commit: b20353c

@bhutz
Copy link
Author

bhutz commented Dec 2, 2014

Dependencies: 17324

@bhutz
Copy link
Author

bhutz commented Dec 2, 2014

Author: Ben Hutz

@bhutz
Copy link
Author

bhutz commented Dec 3, 2014

Changed dependencies from 17324 to #17324

@sagetrac-gjorgenson
Copy link
Mannequin

sagetrac-gjorgenson mannequin commented Dec 3, 2014

comment:7

Just two minor typos in projective_point __eq__, __ne__, projective is spelled wrong

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

ae4317a17429: fixed typos

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2014

Changed commit from b20353c to ae4317a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 6, 2014

Changed commit from ae4317a to 6aa86f9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 6, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

6aa86f9Merge branch 'master' into ticket/17429

@sagetrac-gjorgenson
Copy link
Mannequin

sagetrac-gjorgenson mannequin commented Dec 6, 2014

Reviewer: Grayson Jorgenson

@sagetrac-gjorgenson
Copy link
Mannequin

sagetrac-gjorgenson mannequin commented Dec 6, 2014

comment:10

Looks good. I can't find any additional typos, and the doctests pass

@vbraun
Copy link
Member

vbraun commented Dec 15, 2014

Changed branch from u/bhutz/ticket/17429 to 6aa86f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants