Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated 'dim' argument of MIP variables #17463

Closed
nathanncohen mannequin opened this issue Dec 8, 2014 · 16 comments
Closed

Remove the deprecated 'dim' argument of MIP variables #17463

nathanncohen mannequin opened this issue Dec 8, 2014 · 16 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Dec 8, 2014

The 'dim' attribute of MIPVariables has been deprecated since Sage 6.2 in
#15489. It was always useless since myvar[a,b] works and is more practical
than myvar[a][b]. I had not noticed that when I implemented it T_T

With this ticket, the problem is solved.

CC: @dimpase

Component: numerical

Author: Nathann Cohen

Branch/Commit: d3c8f90

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/17463

@nathanncohen nathanncohen mannequin added this to the sage-6.5 milestone Dec 8, 2014
@nathanncohen nathanncohen mannequin added c: numerical labels Dec 8, 2014
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 8, 2014

Branch: u/ncohen/17463

@nathanncohen nathanncohen mannequin added the s: needs review label Dec 8, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2014

Commit: d3c8f90

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

d3c8f90Removed 'MIPVariable.dim' attribute deprecated in #15489 on 2013-12-06

@dimpase
Copy link
Member

dimpase commented Dec 8, 2014

comment:3

LGTM

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 8, 2014

comment:4

Thanks !

Nathann

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer removed this from the sage-6.5 milestone Dec 8, 2014
@jdemeyer jdemeyer changed the title Remove the (deprecate) 'dim' argument of MIP variables Remove the deprecated 'dim' argument of MIP variables Dec 8, 2014
@vbraun
Copy link
Member

vbraun commented Dec 11, 2014

comment:7

I hope you don't expect me to merge "sage-pending" tickets...

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 12, 2014

comment:8

I do not object to changing the milestone and having it merged tomorrow, if you ask.

Nathann

@vbraun
Copy link
Member

vbraun commented Dec 18, 2014

comment:9

I'm neither the author nor the reviewer (name missing btw).

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 18, 2014

Reviewer: Dima Pasechnik

@vbraun
Copy link
Member

vbraun commented Jan 29, 2015

comment:11

PSA: Once you want the ticket merged you can set a milestone to something else than "sage-pending"

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jan 29, 2015

comment:12

PSA: Once you want the ticket merged you can set a milestone to something else than "sage-pending"

Right right. I asked google calendar to send me an email on the 2015-05-06.

Nathann

@vbraun
Copy link
Member

vbraun commented Jan 29, 2015

comment:13

Just trying to make sure that everybody understands that feature of the merge script since it caused some confusion on another ticket

@jdemeyer jdemeyer added this to the sage-6.7 milestone May 6, 2015
@jdemeyer jdemeyer removed the pending label May 6, 2015
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 6, 2015

comment:15

Oh. Thanks :-D

@jdemeyer

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented May 6, 2015

Changed branch from u/ncohen/17463 to d3c8f90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants