Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Division by monomials in LaurentPolynomialRings should not be in the fraction field #17520

Closed
miguelmarco opened this issue Dec 17, 2014 · 9 comments

Comments

@miguelmarco
Copy link
Contributor

Right now, if we divide a Laurent Polynomial by a monomial, the result will live in the fraction field of the corresponding polynomial ring:

sage: R.<s,q,t>=LaurentPolynomialRing(QQ)
sage: f=s^2*q+q^(-1)*t
sage: f
s^2*q + q^-1*t
sage: f.parent()
Multivariate Laurent Polynomial Ring in s, q, t over Rational Field
sage: f/s
(s^2*q^2 + t)/(s*q)
sage: (f/s).parent()
Fraction Field of Multivariate Polynomial Ring in s, q, t over Rational Field

But monomials here are units, so dividing by them should result in an element of the same ring.

This patch solves this:

sage: R.<s,q,t>=LaurentPolynomialRing(QQ)
sage: f=s^2*q+q^(-1)*t
sage: f.parent()
Multivariate Laurent Polynomial Ring in s, q, t over Rational Field
sage: f/s
s*q + s^-1*q^-1*t
sage: (f/s).parent()
Multivariate Laurent Polynomial Ring in s, q, t over Rational Field

CC: @roed314 @loefflerd

Component: commutative algebra

Keywords: Laurent polynomials

Author: Miguel Marco

Branch/Commit: 91f7773

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/17520

@miguelmarco
Copy link
Contributor Author

Branch: u/mmarco/ticket/17520

@fchapoton
Copy link
Contributor

comment:2

is this needs_review ?


New commits:

e278645Division by monomials in LaurentPolynomialRing stays in the ring.

@fchapoton
Copy link
Contributor

Commit: e278645

@miguelmarco
Copy link
Contributor Author

comment:3

Yes, sorry to forget.

@fchapoton
Copy link
Contributor

comment:4

ok, looks good to me.
I just made a few cosmetic changes in the doc, so I allow myself to put the ticket to positive
review.


New commits:

487ff8eMerge branch 'u/mmarco/ticket/17520' into 6.7
91f7773trac #17520 review commit (minor details)

@fchapoton
Copy link
Contributor

Changed commit from e278645 to 91f7773

@fchapoton
Copy link
Contributor

Changed branch from u/mmarco/ticket/17520 to public/ticket/17520

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented May 21, 2015

Changed branch from public/ticket/17520 to 91f7773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants