Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dangling lazy import for ClassicalCrystalOfAlcovePaths #17521

Closed
gagern mannequin opened this issue Dec 18, 2014 · 6 comments
Closed

Dangling lazy import for ClassicalCrystalOfAlcovePaths #17521

gagern mannequin opened this issue Dec 18, 2014 · 6 comments
Labels
c: combinatorics p: major / 3 t: bug
Milestone
sage-6.5

Comments

@gagern
Copy link
Mannequin

gagern mannequin commented Dec 18, 2014

#16689 forgot to remove a lazy import for ClassicalCrystalOfAlcovePaths:

sage: ClassicalCrystalOfAlcovePaths
<repr(<sage.misc.lazy_import.LazyImport at 0x7f499cc9e188>) failed: AttributeError: 'module' object has no attribute 'ClassicalCrystalOfAlcovePaths'>

Component: combinatorics

Author: Martin von Gagern

Branch/Commit: 9ffcb42

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/17521
@gagern gagern mannequin added this to the sage-6.5 milestone Dec 18, 2014
@gagern gagern mannequin added c: combinatorics labels Dec 18, 2014
@gagern
Copy link
Mannequin Author

gagern mannequin commented Dec 18, 2014

Branch: u/gagern/ticket/17521

@gagern
Copy link
Mannequin Author

gagern mannequin commented Dec 18, 2014

Commit: 9ffcb42

@gagern
Copy link
Mannequin Author

gagern mannequin commented Dec 18, 2014

New commits:

9ffcb42Remove lazy import for ClassicalCrystalOfAlcovePaths.

@gagern gagern mannequin added the s: needs review label Dec 18, 2014
@tscrim
Copy link
Collaborator

tscrim commented Dec 22, 2014

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Dec 22, 2014

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Jan 2, 2015

Changed branch from u/gagern/ticket/17521 to 9ffcb42

@vbraun vbraun closed this as completed in 98f5fd0 Jan 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.5
Development

No branches or pull requests
2 participants
@vbraun @tscrim