New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move simplify_log() from simplify_full() to simplify_real() #17556
Comments
Branch: u/mjo/ticket/17556 |
Author: Michael Orlitzky |
comment:1
Not too much had to be changed for this. Since the 'one' algorithm was used for New commits:
|
Commit: |
Reviewer: Ralf Stephan |
comment:2
|
comment:3
I'm going to need some help from a native speaker to fix that. The context of that sentence is discussing the
Then the failing test mentions (I think) that
but of course that's not the case anymore because the log contraction isn't necessarily valid if One possible solution would be to mention
Another possible solution is to get rid of the |
comment:4
Probably something like this would be appropriate (Ralf, I assume your German is "more native" than mine and can confirm):
and then use That said, I'm not 100% convinced that |
comment:5
Replying to @kcrisman:
I don't like removing them, but I do think we should try to avoid answers that are clearly wrong under the "simplify" name, like the example in the ticket description. We just don't have a lot of good simplifications available that work for complex variables. I did add In any case, this is a much smaller change than it might seem. I mention in the commit messages that the 'one' algorithm was passed to I think the change only affected two doctests (including the German one), and in those cases it's not clear that the variables were supposed to be real, so the answers may be wrong anyway =) With So tl;dr I felt bad removing two things from |
Changed branch from u/mjo/ticket/17556 to u/rws/ticket/17556 |
comment:7
Oops, should have used a public branch. Replying to @kcrisman:
This patch adds such a test, and the sentence reads translated: Since it's practically what you both proposed I'm including it with my positive review. New commits:
|
comment:8
The "die nur mit reellen Werten erlaubt sind" is perfect, great! |
comment:9
Sorry to be so late. I think the following does not sound optimal:
I think in "Additionstheoreme bei Logarithmen", the "bei" is wrong, and also I wouldn't say that a theorem is "erlaubt". What do you think about "werden auch Additionstheoreme verwendet, die nur für reellwertige Logarithmen gelten"? Or at least "werden auch solche Additionstheoreme für Logarithmen angewandt, die nur mit reellen Werten gelten"? (or "anwendbar sind" instead of "gelten") |
comment:10
Do I understand correctly that the purpose of this ticket is not to fix further errors in |
Changed branch from u/rws/ticket/17556 to |
Changed commit from |
comment:12
How about |
The
simplify_log
function assumes that its argument is real; otherwise the log contraction operation is invalid. For example,Now that we have a
simplify_real()
method, why not movesimplify_log()
there instead?In the process, the newer
simplify_rectform()
can be added tosimplify_full()
.I'm working on a patch for this.
Component: symbolics
Author: Michael Orlitzky
Branch:
3616d00
Reviewer: Ralf Stephan
Issue created by migration from https://trac.sagemath.org/ticket/17556
The text was updated successfully, but these errors were encountered: