Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement and use get_unsafe()/set_unsafe() for vectors #17562

Closed
jdemeyer opened this issue Dec 29, 2014 · 33 comments
Closed

Implement and use get_unsafe()/set_unsafe() for vectors #17562

jdemeyer opened this issue Dec 29, 2014 · 33 comments
Labels
c: linear algebra p: major / 3 t: bug
Milestone
sage-6.5

Comments

@jdemeyer
Copy link

Use get_unsafe() and set_unsafe() in the generic __getitem__ and __setitem__ methods for free module elements (a.k.a. vectors).

This should also fix

sage: v=vector(RR,range(6),sparse=True)
sage: v[::2]
(0.000000000000000, 1.00000000000000, 2.00000000000000, 3.00000000000000, 4.00000000000000, 5.00000000000000)

Depends on #17585
Depends on #17850

Component: linear algebra

Author: Jeroen Demeyer

Branch/Commit: d250a42

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/17562
@jdemeyer jdemeyer added this to the sage-6.5 milestone Dec 29, 2014
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/17562

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2014

Commit: b6f6e8c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b6f6e8cImprove and fix `__getitem__` and __setitem__

@jdemeyer
Copy link
Author

Dependencies: #10513

@jdemeyer jdemeyer changed the title FIx vector slicing Fix vector slicing Dec 29, 2014
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Fix vector slicing Implement and use get_unsafe()/set_unsafe() for vectors Dec 29, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2014

Changed commit from b6f6e8c to bcae9f8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

54eed61Trac 10513: move various base_extend() and change_ring() methods to Module
ed13085Trac 10513: various additions, fixes and cleanups
5126b66Trac 10513: remove source line number in doctest
ddda401Merge branch 'develop' into ticket/10513-coercion_and_categories_for_modules
2bb997bMerge branch 'develop' into ticket/10513-coercion_and_categories_for_modules
ed6bbf1Trac 10513: fix doctest
a19e2c5Merge branch 'develop' into ticket/10513-coercion_and_categories_for_modules
2f52a3cTrac 10513: remove unnecessary FreeModule_generic_field.__echelonized_basis_matrix
2d7f075Trac 10513: small documentation improvement
bcae9f8Improve and fix `__getitem__` and __setitem__

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 30, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

027a196Implement get_unsafe() and set_unsafe() for vectors

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 30, 2014

Changed commit from bcae9f8 to 027a196

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 30, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

190d4e0Implement get_unsafe() and set_unsafe() for vectors

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 30, 2014

Changed commit from 027a196 to 190d4e0

@jdemeyer
Copy link
Author

Changed dependencies from #10513 to #10513, #17570

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

Changed dependencies from #10513, #17570 to #10513

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

Changed dependencies from #10513 to #17585

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

dbca6bbImplement coordinate_ring() for free module elements
34ba37dBetter doctests for basis_matrix()
4639cd4Implement get_unsafe() and set_unsafe() for vectors

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Changed commit from 190d4e0 to 4639cd4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Changed commit from 4639cd4 to f398133

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f398133Implement get_unsafe() and set_unsafe() for vectors

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ab7be31Merge remote-tracking branch 'origin/develop' into HEAD
56cc93bImplement get_unsafe() and set_unsafe() for vectors

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Changed commit from f398133 to 56cc93b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Changed commit from 56cc93b to 345f2d8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

345f2d8Implement get_unsafe() and set_unsafe() for vectors

@jdemeyer
Copy link
Author

Changed dependencies from #17585 to #17585, #17850

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Changed commit from 345f2d8 to a8a52bd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3a19fabAdd coordinate_ring argument to free module constructors
6f65751Merge remote-tracking branch 'origin/develop' into HEAD
a8a52bdImplement get_unsafe() and set_unsafe() for vectors

@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 1, 2015

Changed commit from a8a52bd to d250a42

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 1, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

d250a42Merge tag '6.6.beta2' into t/17562/ticket/17562

@videlec
Copy link
Contributor

videlec commented Mar 21, 2015

Reviewer: Vincent Delecroix

@videlec
Copy link
Contributor

videlec commented Mar 21, 2015

comment:21

Looks good.

(follow-up: #18029)

@vbraun
Copy link
Member

vbraun commented Apr 14, 2015

Changed branch from u/jdemeyer/ticket/17562 to d250a42

@vbraun vbraun closed this as completed in 1b5b691 Apr 14, 2015
@simon-king-jena simon-king-jena mentioned this issue Apr 15, 2015
Closed
@jdemeyer jdemeyer mentioned this issue Jan 13, 2015
Closed
@videlec videlec mentioned this issue Dec 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: linear algebra p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.5
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @videlec