New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move bordeaux_2008 into thematic_tutorials #17615
Comments
Branch: public/17615 |
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:3
I won't be thinking about these two tickets immediately, but did want to point out that at least a couple of them may have localizations and I wonder where those would fit. Also be careful about the actual Sage webpage which would need to have links change, probably (looks like you did the "website" in src/doc). |
comment:4
There was no localization problem that I saw, and in particular both html and pdf documentation were built successfully. There is not a single non-ascii character in any of those two folders.
You mean "among the thematic tutorials" ? Nothing unusual there:
I learned the existence of that file while reviewing your patch recently, and modified it in those two branches. It looks good. Nathann |
comment:5
No, I meant I think that someone has translated at least one of these documents already! So they live in some other doc/xy folder. Maybe those are only under review.
Right, but what I mean is that the actual Sage website also has links, see https://github.com/sagemath/website which is not the same. |
comment:6
Hello,
It seems so. There is no folder with a name similar to any of those two in the folder corresponding to other languages.
There does not seem to be any link toward any of those two documents on sagemath.org. Nathann |
comment:7
Incorrect. See http://sagemath.org/help.html#SageStandardDoc and
|
comment:8
Thank you for pointing this out, I missed it. Can it be done with a sage branch, or is it orthogonal ? Nathann |
comment:9
Orthogonal (you can also email Harald for questions, or do a PR there), but obviously related. |
comment:10
Okay. I will do this when those two tickets will be reviewed. There is always some time before a positive review and the next update of the online doc. Nathann |
comment:11
For me this patch is working correctly, and since the modification of some links pointing to these pages cannot be done in this patch, I propose to change the status to positive review. Nathann, don't forget to ask for the required modifications. |
Reviewer: Karl-Dieter Crisman, David Coudert |
comment:12
Done, thanks. |
comment:13
Pushes this test over the threshold:
|
Changed branch from public/17615 to |
Like for #17614, the document entitled "Three Lectures about Explicit Methods in Number Theory Using Sage" is a document of its own though it is literally a thematic tutorial. This branch moves it where it belongs.
Note: in order to look at this branch's diff you should use
git diff -M HEAD ^develop
. Otherwise you will see files being added/removed while they are only renamed. The -M option makes this clear.Nathann
Depends on #17614
CC: @kcrisman @jhpalmieri
Component: documentation
Author: Nathann Cohen
Branch/Commit:
e4f3206
Reviewer: Karl-Dieter Crisman, David Coudert
Issue created by migration from https://trac.sagemath.org/ticket/17615
The text was updated successfully, but these errors were encountered: