Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding theory tutorial: many broken doctests #17617

Closed
nathanncohen mannequin opened this issue Jan 11, 2015 · 7 comments
Closed

Coding theory tutorial: many broken doctests #17617

nathanncohen mannequin opened this issue Jan 11, 2015 · 7 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jan 11, 2015

The examples contained in the coding theory tutorial were never tested because they began with "Sage :" instead of "sage:".

This is reformatted in #17616 but many doctests were broken and were flagged as "not tested". Somebody who understands coding theory should go over them and fix them properly.

Even the sentence

Included in Sage is the group theory package GAP [GAP] and GUAVA [GUAVA], GAP’s coding theory package. All of GUAVA’s functions can be accessed within Sage.

is wrong, as GUAVA is optional, part of gap_packages.

[1] http://www.sagemath.org/doc/thematic_tutorials/coding_theory.html

Depends on #17616

CC: @sagetrac-dlucas

Component: coding theory

Issue created by migration from https://trac.sagemath.org/ticket/17617

@nathanncohen nathanncohen mannequin added this to the sage-6.5 milestone Jan 11, 2015
@jdemeyer

This comment has been minimized.

@wdjoyner
Copy link

comment:2

It appears now "codes." must be preappended: for example,

C = ToricCode([[0,0],[1,0],[2,0],[0,1],[1,1]],GF(7))

becomes

C = codes.ToricCode([[0,0],[1,0],[2,0],[0,1],[1,1]],GF(7))

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jan 13, 2015

comment:3

It appears now "codes." must be preappended: for example,

True. I believe that #17616 already does that wherever it is needed, though.

Nathann

@johanrosenkilde
Copy link
Contributor

comment:4

David, this should be fixed now, right?

@sagetrac-dlucas
Copy link
Mannequin

sagetrac-dlucas mannequin commented Mar 3, 2016

comment:5

Indeed.

All of these were fixed when I completely rewrote this tutorial in #19897.

I don't exactly know what to do in that case though. I know you can set a ticket as closed/invalid/wontfix which it more or less the case here, but I don't know how to do that.

@johanrosenkilde
Copy link
Contributor

comment:6

Like this?

@johanrosenkilde johanrosenkilde removed this from the sage-6.5 milestone Mar 3, 2016
@sagetrac-dlucas
Copy link
Mannequin

sagetrac-dlucas mannequin commented Mar 3, 2016

comment:7

Yes, like this. It was under "milestones", of course...

Anyway, I'm giving a positive review to this closed/invalid/wontfix as the bugs described in this ticket does not exist anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants