Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inherit Group from Monoid #17626

Open
dkrenn opened this issue Jan 12, 2015 · 4 comments
Open

inherit Group from Monoid #17626

dkrenn opened this issue Jan 12, 2015 · 4 comments
Labels
c: algebra p: major / 3 s: needs info t: enhancement

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Jan 12, 2015

The class Group in sage.groups.group is inherited from Parent but not from Monoid since no "nice" monoid-class exists. There is only Monoid_class which seems to be very simplified.

The aim of this ticket is to create a class Monoid and use it as a base-class for Group.

Component: algebra

Branch/Commit: u/dkrenn/new-monoid-class @ 2607990

Issue created by migration from https://trac.sagemath.org/ticket/17626
@dkrenn dkrenn added this to the sage-6.5 milestone Jan 12, 2015
@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 12, 2015

Branch: u/dkrenn/new-monoid-class

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 12, 2015

Last 10 new commits:

a097639add monoid.pxd
b2589b3remove accidentally added method "order" from monoid
8ff4faausing "super" in __init__
3a7b312code rewrapping
63343d8improve docstrings
c51a914cimport Monoid in group.pyx
5296eeederive Group from Monoid
7730f60use super(...).__init__
8e088c0remove duplicate code
2607990restructured imports and removed non-needed

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 12, 2015

Commit: 2607990

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 12, 2015

comment:2

in c51a914 the importing of Monoid in group.pyx fails (sage -t) with

Traceback (most recent call last):
...
AttributeError: 'module' object has no attribute 'all'

Need help... :)

@dkrenn dkrenn changed the title inherite Group from Monoid inherit Group from Monoid Jan 12, 2015
@mkoeppe mkoeppe removed this from the sage-6.5 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: major / 3 s: needs info t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkoeppe @dkrenn