Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stricmp is being deprecated in Cygwin #17641

Closed
jpflori opened this issue Jan 16, 2015 · 12 comments
Closed

stricmp is being deprecated in Cygwin #17641

jpflori opened this issue Jan 16, 2015 · 12 comments

Comments

@jpflori
Copy link

jpflori commented Jan 16, 2015

stricmp is being deprecated in Cygwin
See https://cygwin.com/ml/cygwin/2014-10/msg00359.html
One should use strcasecmp

This makes Singular build fail on Cygwin32 (not Cygwin64 at the moment).

CC: @sagetrac-gouezel @tscrim

Component: porting: Cygwin

Keywords: cygwin singular

Author: Jean-Pierre Flori

Branch/Commit: 7727566

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/17641

@jpflori jpflori added this to the sage-6.5 milestone Jan 16, 2015
@jpflori

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Jan 16, 2015

comment:2

Attachment: stricmp.patch.gz

@videlec
Copy link
Contributor

videlec commented Jan 17, 2015

comment:3

Hi Jean-Pierre,

Did you report upstream? The corresponding field of this track ticket is still N/A.

Vincent

@jpflori
Copy link
Author

jpflori commented Jan 17, 2015

comment:4

Nope, and I won't do so before end of february when I come back to France.
Feel free to do it, but note it is not a high priority as:

  • it only affects Cygwin32
  • I did not check the state of Singular 4-0-x.

@jpflori
Copy link
Author

jpflori commented Feb 26, 2015

Commit: 7727566

@jpflori
Copy link
Author

jpflori commented Feb 26, 2015

Author: Jean-Pierre Flori

@jpflori
Copy link
Author

jpflori commented Feb 26, 2015

Changed keywords from none to cygwin singular

@jpflori
Copy link
Author

jpflori commented Feb 26, 2015

New commits:

7727566stricmp is being depercated on Cygwin.

@jpflori
Copy link
Author

jpflori commented Feb 26, 2015

Branch: u/jpflori/ticket/17641

@tscrim
Copy link
Collaborator

tscrim commented Feb 26, 2015

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 26, 2015

comment:6

LGTM.

@vbraun
Copy link
Member

vbraun commented Feb 27, 2015

Changed branch from u/jpflori/ticket/17641 to 7727566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants