Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

two difference sets #17655

Closed
videlec opened this issue Jan 20, 2015 · 9 comments
Closed

two difference sets #17655

videlec opened this issue Jan 20, 2015 · 9 comments
Labels
c: combinatorial designs p: major / 3 t: enhancement
Milestone
sage-6.5

Comments

@videlec
Copy link
Contributor

videlec commented Jan 20, 2015

It appears that there are two difference sets from http://www.ccrwest.org/diffsets.html that are not yet in Sage... let us have them!

CC: @nathanncohen

Component: combinatorial designs

Author: Vincent Delecroix

Branch/Commit: 39d2f0c

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/17655
@videlec videlec added this to the sage-6.5 milestone Jan 20, 2015
@videlec
Copy link
Contributor Author

videlec commented Jan 20, 2015

Commit: 39d2f0c

@videlec
Copy link
Contributor Author

videlec commented Jan 20, 2015

New commits:

39d2f0ctrac #17655: two difference sets

@videlec
Copy link
Contributor Author

videlec commented Jan 20, 2015

Branch: public/17655

@videlec videlec changed the title two difference set two difference sets Jan 20, 2015
@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jan 20, 2015

comment:2

Thanks to all the checks in the design code, there is nothing to review :-PPP

Nathann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jan 20, 2015

Reviewer: Nathann Cohen

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jan 20, 2015

comment:3

(and even the doc is updated automatically...)

@videlec
Copy link
Contributor Author

videlec commented Jan 20, 2015

comment:4

Thanks (at least you need to be here and set to positive review).

I guess this is the fastest review from creation to positive review... 3 minutes ;-)

Vincent

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jan 20, 2015

comment:5

I guess this is the fastest review from creation to positive review... 3 minutes ;-)

Not sure. You are competing with one-letter typos there.

Nathann

@vbraun
Copy link
Member

vbraun commented Jan 24, 2015

Changed branch from public/17655 to 39d2f0c

@vbraun vbraun closed this as completed in c66a11f Jan 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorial designs p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.5
Development

No branches or pull requests
2 participants
@vbraun @videlec