Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bashisms in src/bin shell scripts #17699

Closed
sagetrac-tmonteil mannequin opened this issue Jan 30, 2015 · 3 comments
Closed

Remove bashisms in src/bin shell scripts #17699

sagetrac-tmonteil mannequin opened this issue Jan 30, 2015 · 3 comments

Comments

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Jan 30, 2015

It seems to increase portability, see e.g. #17513.

Component: scripts

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/17699

@sagetrac-tmonteil sagetrac-tmonteil mannequin added this to the sage-6.5 milestone Jan 30, 2015
@jdemeyer
Copy link

comment:1

We have been assuming bash for a very long time. Removing bashisms would require replacing those scripts by more complicated code, giving more chances of breakage.

And if you stop assuming bash as shell, you have to test that things works on all shells. Again giving more chances of breakage.

Proposal: close as "wontfix".

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer jdemeyer removed this from the sage-6.5 milestone Jan 31, 2015
@a-andre
Copy link

a-andre commented Jan 31, 2015

comment:2

As pointed out by Volker in #15642 comment:13 and [1]

Python is a requirement. Sooner or later Sage won't build without Python

so the shell scripts could be replaced by python scripts as it is done in #15642.

[1] https://groups.google.com/forum/#!topic/sage-devel/akds04MBQYg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants