Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PowerSeries.reversion() in PowerSeries.reverse() #17724

Closed
bgrenet opened this issue Feb 3, 2015 · 6 comments
Closed

Rename PowerSeries.reversion() in PowerSeries.reverse() #17724

bgrenet opened this issue Feb 3, 2015 · 6 comments
Labels
c: commutative algebra p: major / 3 t: enhancement
Milestone
sage-6.5

Comments

@bgrenet
Copy link

bgrenet commented Feb 3, 2015

The method PowerSeries.reversion(self) returns the reverse power series of self. Following the apparent naming convention, I propose to rename it PowerSeries.reverse(self).

It is more consistent with other method such as (for PowerSeries): derivative() (not derivation) or truncate() (not truncation).

Component: commutative algebra

Keywords: reverse, series

Author: Bruno Grenet

Branch/Commit: 05bbf4a

Reviewer: Ralf Stephan

Issue created by migration from https://trac.sagemath.org/ticket/17724
@bgrenet bgrenet added this to the sage-6.5 milestone Feb 3, 2015
@bgrenet
Copy link
Author

bgrenet commented Feb 3, 2015

Branch: u/bruno/rename_powerseries_reversion___in_powerseries_reverse__

@bgrenet
Copy link
Author

bgrenet commented Feb 3, 2015

Commit: 05bbf4a

@bgrenet
Copy link
Author

bgrenet commented Feb 3, 2015

New commits:

05bbf4aReplace reversion by reverse

@rwst
Copy link

rwst commented Feb 4, 2015

Reviewer: Ralf Stephan

@rwst
Copy link

rwst commented Feb 4, 2015

comment:3

Looks fine. Thanks.

@vbraun
Copy link
Member

vbraun commented Feb 18, 2015

Changed branch from u/bruno/rename_powerseries_reversion___in_powerseries_reverse__ to 05bbf4a

@vbraun vbraun closed this as completed in 7fc4cfa Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: commutative algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.5
Development

No branches or pull requests
3 participants
@vbraun @rwst @bgrenet