Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Weil restriction for affine schemes/points/morphisms #17729

Closed
bhutz opened this issue Feb 4, 2015 · 13 comments
Closed

Implement Weil restriction for affine schemes/points/morphisms #17729

bhutz opened this issue Feb 4, 2015 · 13 comments

Comments

@bhutz
Copy link

bhutz commented Feb 4, 2015

#5569 implements Weil restriction (restriction of scalars) for ideals. This will extend that to affine schemes and also points and morphisms of affine schemes.

Component: algebraic geometry

Author: Ben Hutz

Branch/Commit: 8bacaf5

Reviewer: Joao Alberto de Faria

Issue created by migration from https://trac.sagemath.org/ticket/17729

@bhutz bhutz added this to the sage-6.5 milestone Feb 4, 2015
@bhutz bhutz self-assigned this Feb 4, 2015
@bhutz
Copy link
Author

bhutz commented Feb 6, 2015

Branch: u/bhutz/ticket/17729

@bhutz
Copy link
Author

bhutz commented Feb 6, 2015

Author: Ben Hutz

@bhutz
Copy link
Author

bhutz commented Feb 6, 2015

comment:2

Note that when I implemented this I noticed that the original implementation for ideals was inconsistently ordering the coordinates. In particular it labelled a^2x2 + ax1 + ax0 and then created the coordinates (x2,x1,x0) in the ring k[x0,x1,x2]. This caused issues for morphisms, so I made this consistent: i.e. coordinates (x0,x1,x2). I also allowed for weil restrictions of relative number fields (to the base field) instead of just absolute number fields. These are the only two changes to the original implementation.


New commits:

c1294c317729: implement weil restriction for affine schemes

@bhutz
Copy link
Author

bhutz commented Feb 6, 2015

Commit: c1294c3

@sagetrac-jdefaria
Copy link
Mannequin

sagetrac-jdefaria mannequin commented Feb 24, 2015

comment:3

Outside of the merge issue, in the affine point folder, the weil restriction function should be calling min_poly and not absolute_minpoly, otherwise it won't work for relative field extensions, (also put a better relative field extension example)

@sagetrac-jdefaria
Copy link
Mannequin

sagetrac-jdefaria mannequin commented Feb 24, 2015

Reviewer: Joao Alberto de Faria

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Changed commit from c1294c3 to e06c496

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

42b4cb1Merge branch 'master' into ticket/17729
e06c49617729: fixed minor issues from review

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Changed commit from e06c496 to 8bacaf5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

8bacaf5Merge branch 'master' into ticket/17729

@bhutz
Copy link
Author

bhutz commented Feb 24, 2015

comment:6

fixed a merge issues with beta0, then there was another merge issues with beta1. All fixed now.

@bhutz bhutz modified the milestones: sage-6.5, sage-6.6 Feb 24, 2015
@sagetrac-jdefaria
Copy link
Mannequin

sagetrac-jdefaria mannequin commented Mar 2, 2015

comment:7

Went through and did some sanity checking, ran a long test just to be sure, looks clean, setting to positive review

@vbraun
Copy link
Member

vbraun commented Mar 3, 2015

Changed branch from u/bhutz/ticket/17729 to 8bacaf5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants