-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runsnake() cleanup #17735
Comments
comment:2
See also #14414. In fact, I'm inclined to close this ticket as "dupe" and address the issues mentioned here on that ticket. |
Branch: u/tmonteil/runsnake___cleanup |
New commits:
|
This comment has been minimized.
This comment has been minimized.
Commit: |
comment:5
Replying to @nbruin:
Thanks for the pointer, i did not see it.
This ticket adresses different (and more trivial) issues (doc, preparsing, checks) that do not require to wait for a |
comment:6
Replying to @sagetrac-tmonteil:
OK, it's also possible to repurpose #14414 for providing the infrastructure to install runsnake in sage itself. In that case, you would need to do something along the lines of [#14414 comment:23] because checking if runsnake is available and then invoking it in an inappropriate fashion is not an improvement. I have tested that the following works for me (the code on the #14414 comment needed some adjustments)
I really need all of PYTHONHOME, PYTHONPATH, LD_LIBRARY_PATH reset. Failure depends on I can help testing/reviewing if you're ok with that approach (but we need to test on multiple platforms). |
comment:7
Replying to @nbruin:
Why not.
I like the |
comment:8
Setting #9386 as a dependency, since that now offers a saner |
Dependencies: 17746 |
Changed dependencies from 17746 to 9386 |
Changed dependencies from 9386 to #9386 |
comment:12
Looking at the implementation of sage.misc.sage_ostools.have_program, we might want to change: - if os.access(os.path.join(p, program), os.X_OK):
+ pth=os.path.join(p, program)
+ if os.path.isfile(pth) and os.access(pth, os.X_OK): since |
This ticket aims at cleaning
runsnake()
function to:See also #14414 and #17689.
Depends on #9386
Depends on #14414
CC: @nathanncohen
Component: misc
Branch/Commit: u/tmonteil/runsnake___cleanup @
ecaf052
Issue created by migration from https://trac.sagemath.org/ticket/17735
The text was updated successfully, but these errors were encountered: