Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrapper_parent.pyx #17738

Closed
jdemeyer opened this issue Feb 6, 2015 · 10 comments
Closed

Remove wrapper_parent.pyx #17738

jdemeyer opened this issue Feb 6, 2015 · 10 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Feb 6, 2015

The file src/sage/structure/wrapper_parent.pyx is nowhere used in Sage, not doctested, and hasn't seen any non-trivial change since 2008. Moreover, there is almost no actual code, so even if it's not broken, it doesn't do much. Just remove it.

Component: coercion

Author: Jeroen Demeyer

Branch/Commit: 307c237

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/17738

@jdemeyer jdemeyer added this to the sage-6.5 milestone Feb 6, 2015
@jdemeyer
Copy link
Author

jdemeyer commented Feb 6, 2015

Branch: u/jdemeyer/ticket/17738

@jdemeyer
Copy link
Author

jdemeyer commented Feb 6, 2015

New commits:

307c237Remove wrapper_parent

@jdemeyer
Copy link
Author

jdemeyer commented Feb 6, 2015

Commit: 307c237

@mezzarobba
Copy link
Member

comment:3

Why? Is it broken? Does it have a significant maintenance cost? Is there a better mechanism to achieve what it was intended for?

@jdemeyer
Copy link
Author

jdemeyer commented Feb 6, 2015

comment:4

Replying to @mezzarobba:

Is it broken?

Given that it's not used, not doctested, and not maintained since 2008, it is very likely broken. Moreover, there is almost no actual code, so even if it's not broken, it doesn't do much.

Does it have a significant maintenance cost?

Not significant, but there is some maintanance cost: every time we deprecate or change something that this module uses, we have to update it.

Is there a better mechanism to achieve what it was intended for?

Your question seems to assume that this module itself achieves what it was intended for. I don't know if that's the case. Given the little code, I doubt it. In any case, I would need to understand better what it was intented for...

@jdemeyer
Copy link
Author

jdemeyer commented Feb 6, 2015

comment:5

Let me also add that there is no discussion on Trac nor on sage-devel mentioning this module, so I very much doubt that it will be missed (and if so, it's still in the git history).

@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@mezzarobba
Copy link
Member

comment:6

Sound convincing :-)

@mezzarobba

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Feb 18, 2015

Changed branch from u/jdemeyer/ticket/17738 to 307c237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants