New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wrapper_parent.pyx #17738
Comments
Branch: u/jdemeyer/ticket/17738 |
New commits:
|
Commit: |
comment:3
Why? Is it broken? Does it have a significant maintenance cost? Is there a better mechanism to achieve what it was intended for? |
comment:4
Replying to @mezzarobba:
Given that it's not used, not doctested, and not maintained since 2008, it is very likely broken. Moreover, there is almost no actual code, so even if it's not broken, it doesn't do much.
Not significant, but there is some maintanance cost: every time we deprecate or change something that this module uses, we have to update it.
Your question seems to assume that this module itself achieves what it was intended for. I don't know if that's the case. Given the little code, I doubt it. In any case, I would need to understand better what it was intented for... |
comment:5
Let me also add that there is no discussion on Trac nor on |
Reviewer: Marc Mezzarobba |
comment:6
Sound convincing :-) |
This comment has been minimized.
This comment has been minimized.
Changed branch from u/jdemeyer/ticket/17738 to |
The file
src/sage/structure/wrapper_parent.pyx
is nowhere used in Sage, not doctested, and hasn't seen any non-trivial change since 2008. Moreover, there is almost no actual code, so even if it's not broken, it doesn't do much. Just remove it.Component: coercion
Author: Jeroen Demeyer
Branch/Commit:
307c237
Reviewer: Marc Mezzarobba
Issue created by migration from https://trac.sagemath.org/ticket/17738
The text was updated successfully, but these errors were encountered: