clean-up of Tamari lattice and add them as example of poset

[fchapoton]

Two aims:

• clean the code of tamari_lattices.py (into pep8 standard)

• add TamariLattice as an example so that one can type posets.TamariLattice(4)

CC: @darijgr @tscrim @nathanncohen @VivianePons

Component: combinatorics

Keywords: poset, tamari, combinat

Author: Frédéric Chapoton

Branch/Commit: fd6c2b0

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/17761

[fchapoton]

New commits:

30772ca

trac 17XXX : cleanup of Tamari lattice code, + adding them as posets example

[fchapoton]

Commit: 30772ca

[fchapoton]

Branch: u/chapoton/17761

[fchapoton]

Changed keywords from none to poset, tamari, combinat

[nathanncohen]

comment:3

Looks good.

The module documentation begins by telling the user how to import TamariLattice, however, which is not needed anymore with your new alias. Could you update that too ?

Thanks,

Nathann

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

436adad	Merge branch 'u/chapoton/17761' into 6.6.b0
e5694ab	trac #17761 reviewer's comments : Tamari from posets catalogue

[sagetrac-git]

Changed commit from 30772ca to e5694ab

[nathanncohen]

comment:5

O_o

Is there any reason why we should have import only TamariLattices in posets.* and not the generalized ones ?

[fchapoton]

comment:6

Thanks Nathann.

I have chosen not to expose the GeneralizedTamariLattice in the catalogue of posets, as they are not classical at all. So far, only very well known things appear in the catalogue. I think nobody knows about the GeneralizedTamariLattice so far, or maybe call some other posets by this name..

[nathanncohen]

comment:7

Yo !

I have chosen not to expose the GeneralizedTamariLattice in the catalogue of posets, as they are not classical at all. So far, only very well known things appear in the catalogue.

Okay, makes total sense. I'll make a final pass and change this ticket's status.

Nathann

[nathanncohen]

comment:8

Hello !

I added a small commit on top of yours (by the way it looks that you are not using 6.6.beta0 despite what you merge commit claims). It is at public/17761.

If this is fine for you, you can change this ticket's branch and set the ticket to positive_review.

Thanks for this patch,

Nathann

[nathanncohen]

Reviewer: Nathann Cohen

[fchapoton]

Changed commit from e5694ab to fd6c2b0

[fchapoton]

Changed branch from u/chapoton/17761 to public/17761

[fchapoton]

comment:9

Oh, damn, forgot to pull develop. Well.

Thanks a lot Nathann !

---

New commits:

24837e2	trac #17761: Merged with 6.6.beta0
fd6c2b0	trac #17761: Light rephrase

[vbraun]

Changed branch from public/17761 to fd6c2b0