sage -n ipython broken

[cheuberg]

From 6.5.rc0 on,

    sage -n ipython

does no longer work, it starts the sagenb notebook with directory ipython.sagenb.

Until 6.5.beta6, this opened the ipython notebook.

sage -n -h says:

   --notebook [NOTEBOOK], -n [NOTEBOOK], -notebook [NOTEBOOK]
                        The notebook to run [one of: default, ipython,
                        sagenb]. Default is sagenb

sage -h says

  -n, --notebook      -- shortcut for --notebook=default

So these two bits of documentation contradict each other and we have a change of
behaviour.

CC: @kiwifb @rbeezer

Component: scripts

Keywords: notebook

Author: Volker Braun

Branch: 8dc0a94

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/17769

[cheuberg]

comment:1

I do not know whether this is intentional, especially after the discussions in #17280
where we broke old behaviour already once.

I guess that this has been introduced in #17685

[sagetrac-tmonteil]

comment:3

Replying to @cheuberg:

I guess that this has been introduced in #17685

No, the changes made here only concern the -n=blah calls, you can still do sage -n=ipython.

[sagetrac-tmonteil]

comment:4

More precisely, the problem is here

if [ "$1" = "-notebook" -o "$1" = '--notebook' -o "$1" = '-n' ]; then
    shift
    sage-cleaner >/dev/null 2>&1 &
    exec sage-notebook --notebook=default "$@"
fi

It was introduced in sagemath/sagetrac-mirror@487807c

As you can see, the 'default' notebook is explicitly called (consistently with sage -h).

Ciao,
Thierry

[vbraun]

Branch: u/vbraun/sage__n_ipython_broken

[vbraun]

Commit: 8dc0a94

[vbraun]

comment:6

The previous if clause triggered before #17685, so it is technically caused by that ticket.

---

New commits:

8dc0a94

let sage-notebook deal with default options

[vbraun]

Author: Volker Braun

[kiwifb]

comment:8

After inspection of what sage-notebook can parse, it looks good to me.

[vbraun]

Reviewer: François Bissey

[vbraun]

Changed branch from u/vbraun/sage__n_ipython_broken to 8dc0a94

[fchapoton]

Changed commit from 8dc0a94 to none