Modernize NTL error handler

[jdemeyer]

Move the NTL error handler out of c_lib to a Cython module. Also create a new exception class NTLError (inheriting from RuntimeError to not break backwards compatibility). All this is completely analogous to the PARI error handler.

CC: @pjbruin @defeo

Component: c_lib

Author: Jeroen Demeyer

Branch/Commit: 7f5bb61

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/17784

[jdemeyer]

Branch: u/jdemeyer/ticket/17784

[jdemeyer]

Commit: 564f839

[jdemeyer]

New commits:

564f839

Move NTL error handler to Cython

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e11e0e8

Rename ntl/handle_error.pyx to ntl/error.pyx

[sagetrac-git]

Changed commit from 564f839 to e11e0e8

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4546327

Add doctest to make coverage script happy

[sagetrac-git]

Changed commit from e11e0e8 to 4546327

[tscrim]

comment:6

Given the new .pxd file, do we still need the setup_NTL_error_callback as defined in c_lib/src/ntl_wrap.cpp and c_lib/include/ntl_wrap.h?

Also you're missing a colon in EXAMPLES: in setup_NTL_error_callback().

[jdemeyer]

comment:7

Replying to @tscrim:

Given the new .pxd file, do we still need the setup_NTL_error_callback as defined in c_lib/src/ntl_wrap.cpp and c_lib/include/ntl_wrap.h?

No, we no longer need that function. But removing ntl_wrap will be a different ticket.

[sagetrac-git]

Changed commit from 4546327 to 7f5bb61

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7f5bb61

Fix docstring formatting

[tscrim]

comment:9

Alright, positive review then.

[tscrim]

Reviewer: Travis Scrimshaw

[vbraun]

Changed branch from u/jdemeyer/ticket/17784 to 7f5bb61