Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure the gp interface in a single place #17796

Closed
SnarkBoojum mannequin opened this issue Feb 17, 2015 · 14 comments
Closed

Configure the gp interface in a single place #17796

SnarkBoojum mannequin opened this issue Feb 17, 2015 · 14 comments
Labels
c: packages: standard p: minor / 4 t: enhancement
Milestone
sage-6.5

Comments

@SnarkBoojum
Copy link
Mannequin

SnarkBoojum mannequin commented Feb 17, 2015

The gp interface configuration is split between the gprc.expect file shipped by the pari spkg, and the src/sage/interface/gp.py code.

I would like everything to be done in the gp.py code.

I'll try to attach a branch fixing the issue as soon as I manage to make git-trac behave.

Component: packages: standard

Author: Julien Puydt

Branch/Commit: 07e72f1

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/17796
@SnarkBoojum SnarkBoojum mannequin added this to the sage-6.5 milestone Feb 17, 2015
@SnarkBoojum SnarkBoojum mannequin added the p: major / 3 label Feb 17, 2015
@SnarkBoojum

This comment has been minimized.

Sign in to view
@SnarkBoojum SnarkBoojum mannequin added p: minor / 4 and removed p: major / 3 labels Feb 17, 2015
@SnarkBoojum SnarkBoojum mannequin changed the title help Configure the gp interface in a single place Feb 17, 2015
@SnarkBoojum
Copy link
Mannequin Author

SnarkBoojum mannequin commented Feb 17, 2015

Branch: u/Snark/help

@SnarkBoojum
Copy link
Mannequin Author

SnarkBoojum mannequin commented Feb 17, 2015

comment:3

Ok, the branch name is pretty bad (I thought "git trac create -h" would give me help, not create a ticket and call everything help...), but here it compiles and passes all doctests.

New commits:

89e7171Push all configuration in the gp interface code

@SnarkBoojum
Copy link
Mannequin Author

SnarkBoojum mannequin commented Feb 17, 2015

Commit: 89e7171

@SnarkBoojum SnarkBoojum mannequin added the s: needs review label Feb 17, 2015
@jdemeyer
Copy link

comment:4

Typo: hand -> hang

Also, could you please document the reason for the --fast flag?

@jdemeyer
Copy link

comment:5

You don't need 'default(compatible,0);' since that's the default.

@jdemeyer
Copy link

comment:6

And given that this is an incompatible change, the patchlevel of the PARI package should be increased.

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

07e72f1Better patch for gprc removal, following Jeroen's review:

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2015

Changed commit from 89e7171 to 07e72f1

@vbraun
Copy link
Member

vbraun commented Feb 19, 2015

comment:8

trying to set to "needs review" as mentioned on sage-devel

@jdemeyer
Copy link

comment:9

Author name please...

@SnarkBoojum
Copy link
Mannequin Author

SnarkBoojum mannequin commented Feb 20, 2015

Author: Julien Puydt

@vbraun
Copy link
Member

vbraun commented Feb 21, 2015

Changed branch from u/Snark/help to 07e72f1

@vbraun vbraun closed this as completed in 30ee360 Feb 21, 2015
@simon-king-jena simon-king-jena mentioned this issue Dec 1, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-6.5
Development

No branches or pull requests
2 participants
@vbraun @jdemeyer