Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RealBall: Document input aliasing #17809

Closed
cheuberg opened this issue Feb 19, 2015 · 9 comments
Closed

RealBall: Document input aliasing #17809

cheuberg opened this issue Feb 19, 2015 · 9 comments

Comments

@cheuberg
Copy link
Contributor

Add a warning that identical balls are assumed to represent the same number.

Depends on #17194

CC: @mezzarobba @fredrik-johansson

Component: numerical

Keywords: arb, RealBall

Author: Clemens Heuberger

Branch/Commit: 178f31e

Reviewer: Fredrik Johansson, Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/17809

@cheuberg cheuberg added this to the sage-6.6 milestone Feb 19, 2015
@cheuberg
Copy link
Contributor Author

Branch: u/cheuberg/rings/real_arb_doc

@cheuberg
Copy link
Contributor Author

Commit: a445cf9

@cheuberg
Copy link
Contributor Author

comment:2

As discussed in #17194, input aliasing should be documented.


Last 10 new commits:

aa39c10#17194 RealBall: abstract away access to parent precision
d3e3998#17194 RBF: add a precision() method
ce51f81#17194 RBF: some more is_foo() and similar methods
1d92acfTrac #17194: remove fmpr.pxd (partial revert of dd8933a)
5e41fcbTrac #17194: remove imports of fmpr
4e7ec46Trac #17194: is_zero, is_nonzero, is_exact
9e26152Trac #17194: Implement comparisons
1196b57Trac #17194: Fix RealBallField._an_element_
195a6eeTrac #17194: Fix two broken references
a445cf9Trac #17809: Document input aliasing

@fredrik-johansson
Copy link

comment:3

Is it obvious that "identical real balls" means the same Sage object, not different objects with identical values?

I guess the example should be z = x * x, not z = x^2, as the latter would be correct regardless.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

178f31eTrac #17809: x*x instead of x^2; mention RealBall objects

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2015

Changed commit from a445cf9 to 178f31e

@cheuberg
Copy link
Contributor Author

comment:5

Replying to @fredrik-johansson:

Is it obvious that "identical real balls" means the same Sage object, not different objects with identical values?

I hope that it is clearer now.

I guess the example should be z = x * x, not z = x^2, as the latter would be correct regardless.

Of course, thank you, fixed.

@mezzarobba
Copy link
Member

Reviewer: Fredrik Johansson, Marc Mezzarobba

@vbraun
Copy link
Member

vbraun commented Feb 27, 2015

Changed branch from u/cheuberg/rings/real_arb_doc to 178f31e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants