Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RealBall: sig_on for arb_to_mpfi #17811

Closed
cheuberg opened this issue Feb 19, 2015 · 12 comments
Closed

RealBall: sig_on for arb_to_mpfi #17811

cheuberg opened this issue Feb 19, 2015 · 12 comments

Comments

@cheuberg
Copy link
Contributor

As discussed in #17194, arb_to_mpfi might run into an overflow and this should be guarded by a sig_on/sig_off pair.

Depends on #17194

CC: @mezzarobba @fredrik-johansson

Component: numerical

Keywords: arb, RealBall

Author: Clemens Heuberger

Branch/Commit: 33ee7f2

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/17811

@cheuberg cheuberg added this to the sage-6.6 milestone Feb 19, 2015
@cheuberg
Copy link
Contributor Author

@cheuberg
Copy link
Contributor Author

Commit: dce7ed3

@cheuberg
Copy link
Contributor Author

comment:2

The doctest checking whether this actually works is clumsy as the necessary arithmetic operations are not readily available yet; so this has to be done in cython. Eventually, the doctest should be replaced.


Last 10 new commits:

aa39c10#17194 RealBall: abstract away access to parent precision
d3e3998#17194 RBF: add a precision() method
ce51f81#17194 RBF: some more is_foo() and similar methods
1d92acfTrac #17194: remove fmpr.pxd (partial revert of dd8933a)
5e41fcbTrac #17194: remove imports of fmpr
4e7ec46Trac #17194: is_zero, is_nonzero, is_exact
9e26152Trac #17194: Implement comparisons
1196b57Trac #17194: Fix RealBallField._an_element_
195a6eeTrac #17194: Fix two broken references
dce7ed3Trac #17811: sig_on for arb_to_mpfi

@jdemeyer
Copy link

comment:3

According to the doctest, your exception is ignored. See http://docs.cython.org/src/userguide/language_basics.html#error-return-values for how to fix this.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

0e5b904Trac #17811: declare exception value
4215322Trac #17811: catch error and free memory in any case

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2015

Changed commit from dce7ed3 to 4215322

@cheuberg
Copy link
Contributor Author

comment:5

Replying to @jdemeyer:

According to the doctest, your exception is ignored. See http://docs.cython.org/src/userguide/language_basics.html#error-return-values for how to fix this.

Thanks for the pointer, fixed.

@jdemeyer
Copy link

comment:6

Instead of cdef void ..... except * it's more efficient to do cdef int ..... except -1.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2015

Changed commit from 4215322 to 33ee7f2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

33ee7f2Trac #17811: use int ... except -1: instead of void ... except *

@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@vbraun
Copy link
Member

vbraun commented Feb 28, 2015

Changed branch from u/cheuberg/rings/real_arb_sig_arb_to_mpfi to 33ee7f2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants