Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fixes for some doctest in combinat #17901

Closed
fchapoton opened this issue Mar 5, 2015 · 6 comments
Closed

minor fixes for some doctest in combinat #17901

fchapoton opened this issue Mar 5, 2015 · 6 comments
Labels
c: combinatorics p: major / 3 t: enhancement t: tests
Milestone
sage-6.6

Comments

@fchapoton
Copy link
Contributor

There are some #indirect doctests that are not tagged as such in the combinat folder.

Let us correct that.

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 6ac13ca

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/17901
@fchapoton fchapoton added this to the sage-6.6 milestone Mar 5, 2015
@fchapoton
Copy link
Contributor Author

Commit: 6ac13ca

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/17901

@fchapoton
Copy link
Contributor Author

New commits:

7124ea2trac #17XXX correcting some bad doctests in combinat
6ac13catrac #17901 correct one doctest

@tscrim
Copy link
Collaborator

tscrim commented Mar 6, 2015

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Mar 6, 2015

comment:2

LGTM (for future reference, because _ascii_art_ is a Sage-special method (1 leading and trailing underscore) it doesn't need an # indirect doctest).

@vbraun
Copy link
Member

vbraun commented Mar 8, 2015

Changed branch from u/chapoton/17901 to 6ac13ca

@vbraun vbraun closed this as completed in 64052fd Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement t: tests
Projects
None yet
Milestone
sage-6.6
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton