New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement connected components for posets #17911
Comments
Commit: |
New commits:
|
comment:2
Hello Travis, Could you add this new function to the index of poset methods, at the top of the file ? Thanks, Nathann |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
I am sorry I did not notice it earlier, but your doctest has an output which can potentially be architecture dependent, i.e. the list of two posets on 5 and 3 elements. You can easily fix it by creating a poset with two connected components on 5 elements. Nathann |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:6
I fixed it by sorting the output based on the size of each connected component. |
comment:7
Okay, that does te job too. Good to go! Nathann |
Reviewer: Nathann Cohen |
Changed branch from public/combinat/posets/connected_components-17911 to |
comment:9
Thanks for doing the review Nathann. |
Changed commit from |
Currently
connected_components
is missing forPoset
, and a useful/common feature to have.CC: @sagetrac-sage-combinat
Component: combinatorics
Keywords: posets
Author: Travis Scrimshaw
Branch:
0ca72f3
Reviewer: Nathann Cohen
Issue created by migration from https://trac.sagemath.org/ticket/17911
The text was updated successfully, but these errors were encountered: