Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement connected components for posets #17911

Closed
tscrim opened this issue Mar 8, 2015 · 15 comments
Closed

Implement connected components for posets #17911

tscrim opened this issue Mar 8, 2015 · 15 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Mar 8, 2015

Currently connected_components is missing for Poset, and a useful/common feature to have.

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: posets

Author: Travis Scrimshaw

Branch: 0ca72f3

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/17911

@tscrim
Copy link
Collaborator Author

tscrim commented Mar 8, 2015

Commit: 02413ef

@tscrim
Copy link
Collaborator Author

tscrim commented Mar 8, 2015

@tscrim
Copy link
Collaborator Author

tscrim commented Mar 8, 2015

New commits:

02413efImplement connected components for posets.

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Mar 8, 2015

comment:2

Hello Travis,

Could you add this new function to the index of poset methods, at the top of the file ?

Thanks,

Nathann

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 9, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

d27121bAdding method to header information.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 9, 2015

Changed commit from 02413ef to d27121b

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Mar 9, 2015

comment:4

I am sorry I did not notice it earlier, but your doctest has an output which can potentially be architecture dependent, i.e. the list of two posets on 5 and 3 elements.

You can easily fix it by creating a poset with two connected components on 5 elements.

Nathann

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 10, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

0ca72f3Making doctest output constant.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 10, 2015

Changed commit from d27121b to 0ca72f3

@tscrim
Copy link
Collaborator Author

tscrim commented Mar 10, 2015

comment:6

I fixed it by sorting the output based on the size of each connected component.

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Mar 10, 2015

comment:7

I fixed it by sorting the output based on the size of each connected component.

Okay, that does te job too. Good to go!

Nathann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Mar 10, 2015

Reviewer: Nathann Cohen

@vbraun
Copy link
Member

vbraun commented Mar 10, 2015

Changed branch from public/combinat/posets/connected_components-17911 to 0ca72f3

@tscrim
Copy link
Collaborator Author

tscrim commented Mar 11, 2015

comment:9

Thanks for doing the review Nathann.

@tscrim
Copy link
Collaborator Author

tscrim commented Mar 11, 2015

Changed commit from 0ca72f3 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants