Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jinja2 is too old #17960

Closed
vbraun opened this issue Mar 15, 2015 · 21 comments
Closed

Jinja2 is too old #17960

vbraun opened this issue Mar 15, 2015 · 21 comments

Comments

@vbraun
Copy link
Member

vbraun commented Mar 15, 2015

If you try to save ipython notebooks as pdf, you'll get the following error

$ sage -ipython nbconvert Untitled.ipynb --to pdf
[...]
  File "/home/vbraun/Code/sage.git/local/lib/python2.7/site-packages/IPython/nbconvert/exporters/../templates/latex/skeleton/null.tplx", line 34, in block "any_cell"
    ((*- block codecell scoped -*))
  File "/home/vbraun/Code/sage.git/local/lib/python2.7/site-packages/IPython/nbconvert/exporters/../templates/latex/skeleton/null.tplx", line 35, in block "codecell"
    ((*- block input_group -*))
  File "/home/vbraun/Code/sage.git/local/lib/python2.7/site-packages/IPython/nbconvert/exporters/../templates/latex/skeleton/null.tplx", line 37, in block "input_group"
    ((*- block input -*))((*- endblock input -*))
  File "/home/vbraun/Code/sage.git/local/lib/python2.7/site-packages/IPython/nbconvert/exporters/../templates/latex/style_ipython.tplx", line 23, in block "input"
    ((( add_prompt(cell.source | highlight_code(strip_verbatim=True), cell, 'In ', 'incolor') )))
UndefinedError: 'add_prompt' is undefined

Workaround is sage -pip install --upgrade jinja2

New vanilla tarball is already on the Sage mirror.

CC: @kiwifb

Component: packages: standard

Author: Volker Braun

Branch/Commit: caaebf4

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/17960

@vbraun vbraun added this to the sage-6.6 milestone Mar 15, 2015
@vbraun
Copy link
Member Author

vbraun commented Mar 15, 2015

Branch: u/vbraun/jinja2_is_too_old

@vbraun
Copy link
Member Author

vbraun commented Mar 15, 2015

Commit: bb4e7dc

@vbraun

This comment has been minimized.

@vbraun
Copy link
Member Author

vbraun commented Mar 15, 2015

Author: Volker Braun

@vbraun
Copy link
Member Author

vbraun commented Mar 15, 2015

New commits:

bb4e7dcupdate to Jinja2-2.7.3

@kiwifb
Copy link
Member

kiwifb commented Mar 15, 2015

comment:3

Well, that will put you on par with sage-on-gentoo. Using that version since last November. +ing.

@vbraun
Copy link
Member Author

vbraun commented Mar 15, 2015

Reviewer: François Bissey

@kiwifb
Copy link
Member

kiwifb commented Mar 15, 2015

comment:5

Darn I reverted to my default state of not putting my name after breakfast.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 16, 2015

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

f666b00Jinja2 now depends on MarkupSafe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 16, 2015

Changed commit from bb4e7dc to f666b00

@vbraun
Copy link
Member Author

vbraun commented Mar 16, 2015

comment:7

Markupsafe is a new dependency of jinja...

@kiwifb
Copy link
Member

kiwifb commented Mar 16, 2015

comment:8

Indeed I hadn't checked that. From what I can see it is the only one (apart from setuptools and sphinx if you want to build the doc). It appears that docutils is not a dependency of jinja2 anymore, I guess that's were sphinx is coming in.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 16, 2015

Changed commit from f666b00 to caaebf4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 16, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

caaebf4Jinja depends on Sphinx instead of docutils

@vbraun
Copy link
Member Author

vbraun commented Mar 16, 2015

comment:11

sphinx depends on docutils for the record...

@kiwifb
Copy link
Member

kiwifb commented Mar 16, 2015

comment:12

Replying to @vbraun:

sphinx depends on docutils for the record...

That's a good record.

@kcrisman
Copy link
Member

comment:13

No implications for sagenb, I assume?

@kiwifb
Copy link
Member

kiwifb commented Mar 17, 2015

comment:14

None that I can see. Do you have something particular you want tested since I have the stuff in sage-on-gentoo at the 6.6.beta5 level?

@kcrisman
Copy link
Member

comment:15

As long as templating and the server actually work and you don't see any obvious errors of that type, I guess it's okay. I think flask depends on jinja2, right?

@kiwifb
Copy link
Member

kiwifb commented Mar 17, 2015

comment:16
fbissey@QCD-nzi3 ~ $ equery d jinja 
 * These packages depend on jinja:
dev-python/flask-0.10.1-r1 (>=dev-python/jinja-2.4[python_targets_python2_7(-)?,python_targets_python3_3(-)?,python_targets_python3_4(-)?,python_targets_pypy(-)?,-python_single_target_python2_7(-),-python_single_target_python3_3(-),-python_single_target_python3_4(-),-python_single_target_pypy(-)])
dev-python/flask-babel-0.8-r1 (>=dev-python/jinja-2.5[python_targets_python2_7(-)?,-python_single_target_python2_7(-)])
dev-python/ipython-3.0.0 (test ? dev-python/jinja[python_targets_python2_7(-)?,python_targets_python3_3(-)?,python_targets_python3_4(-)?,-python_single_target_python2_7(-),-python_single_target_python3_3(-),-python_single_target_python3_4(-)])
                         (notebook ? dev-python/jinja[python_targets_python2_7(-)?,python_targets_python3_3(-)?,python_targets_python3_4(-)?,-python_single_target_python2_7(-),-python_single_target_python3_3(-),-python_single_target_python3_4(-)])
                         (dev-python/jinja[python_targets_python2_7(-)?,python_targets_python3_3(-)?,python_targets_python3_4(-)?,-python_single_target_python2_7(-),-python_single_target_python3_3(-),-python_single_target_python3_4(-)])
dev-python/sphinx-1.2.2 (>=dev-python/jinja-2.3[python_targets_python2_7(-)?,python_targets_python3_3(-)?,python_targets_python3_4(-)?,python_targets_pypy(-)?,-python_single_target_python2_7(-),-python_single_target_python3_3(-),-python_single_target_python3_4(-),-python_single_target_pypy(-)])
sci-mathematics/sage-9999 (>=dev-python/jinja-2.5.5[python_targets_python2_7(-)?,-python_single_target_python2_7(-)])
sci-mathematics/sage-notebook-0.11.4-r2 (>=dev-python/jinja-2.5.5[python_targets_python2_7(-)?,-python_single_target_python2_7(-)])
www-client/chromium-41.0.2272.76 (dev-python/jinja[python_targets_python2_7(-),python_single_target_python2_7(+)])

@vbraun
Copy link
Member Author

vbraun commented Mar 19, 2015

Changed branch from u/vbraun/jinja2_is_too_old to caaebf4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants