Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement category for H, L, R, J trivials monoids #18001

Open
avirmaux mannequin opened this issue Mar 19, 2015 · 44 comments
Open

Implement category for H, L, R, J trivials monoids #18001

avirmaux mannequin opened this issue Mar 19, 2015 · 44 comments

Comments

@avirmaux
Copy link
Mannequin

avirmaux mannequin commented Mar 19, 2015

The aim is to integrate in the main Sage library the mature methods and examples for

  • H-trivial monoids
  • R-trivial monoids
  • L-trivial monoids
  • J-trivial monoids

from the Sage-Semigroups package. https://github.com/nthiery/sage-semigroups

CC: @nthiery @hivert @tscrim @saliola

Component: categories

Keywords: monoids, days64

Branch/Commit: public/18001 @ ea4a971

Issue created by migration from https://trac.sagemath.org/ticket/18001

@avirmaux avirmaux mannequin added this to the sage-6.6 milestone Mar 19, 2015
@avirmaux avirmaux mannequin added c: categories labels Mar 19, 2015
@avirmaux
Copy link
Mannequin Author

avirmaux mannequin commented Mar 19, 2015

Branch: u/virmaux/develop

@avirmaux
Copy link
Mannequin Author

avirmaux mannequin commented Mar 19, 2015

Changed branch from u/virmaux/develop to u/virmaux/monoids

@nthiery
Copy link
Contributor

nthiery commented Apr 21, 2015

New commits:

3b59784Files for H, J, R, L trivial monoids, beginning of the implementation

@nthiery
Copy link
Contributor

nthiery commented Apr 21, 2015

Dependencies: 18265

@nthiery
Copy link
Contributor

nthiery commented Apr 21, 2015

Commit: 3b59784

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 13, 2015

Changed commit from 3b59784 to 4dbdfac

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 13, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

4dbdfac18001: merge with develop

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2016

Changed commit from 4dbdfac to c389ef3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

c6ce64318001: rebase with develop
30c19af18001: rebase
c389ef318001: rebase (h_trivial)

@tscrim
Copy link
Collaborator

tscrim commented Jun 3, 2016

Changed dependencies from 18265 to #18265

@tscrim tscrim modified the milestones: sage-6.6, sage-7.3 Jun 3, 2016
@fchapoton
Copy link
Contributor

Changed branch from u/virmaux/monoids to public/18001

@fchapoton
Copy link
Contributor

comment:7

I have made a cleaner branch, starting from u/virmaux/develop.

I have also corrected a few typos in the new files.


New commits:

906e4f2Merge branch 'u/virmaux/develop' in 7.4.b0

@fchapoton
Copy link
Contributor

Changed commit from c389ef3 to 906e4f2

@fchapoton
Copy link
Contributor

Changed dependencies from #18265 to none

@fchapoton fchapoton modified the milestones: sage-7.3, sage-7.4 Aug 12, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2016

Changed commit from 906e4f2 to 24a1fbd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

24a1fbdtrac 18001 pep8 details

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

204dac1trac 18001 some details

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2016

Changed commit from 24a1fbd to 204dac1

@nthiery

This comment has been minimized.

@nthiery

This comment has been minimized.

@fchapoton

This comment has been minimized.

@fchapoton fchapoton removed this from the sage-7.4 milestone Feb 5, 2018
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 5, 2018

Changed commit from 85ee163 to e473ebf

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 5, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

e473ebfChanging the category of R-trivial monoids example.

@tscrim
Copy link
Collaborator

tscrim commented May 5, 2018

comment:23

Well, it does fix one problem: the enumeration and the lack of a list() method. (I'm not sure if that means some of these methods should actually belong to the finite finitely-generated semigroups category, and I have swept the problem under the run.)

However, it then shows another problem, which seems to be rooted in the test itself. The method j_transversal_of_idempotents returns a list, but this test seems to be expecting a dict. So either the j_transversal_of_idempotents should now return a family whose keys are index_of_regular_j_class or the test itself needs to change. (BTW, there is a bug with j_transversal_of_idempotents; the output is cached, but it is a mutable list.)

@fchapoton
Copy link
Contributor

comment:24

and also a superfluous import

+src/sage/categories/finite_semigroups.py:16: 'sage.categories.finite_enumerated_sets.FiniteEnumeratedSets' imported but unused

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

40afa48Merge branch 'public/18001' in 9.2.b3
4f7ad67fix one doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2020

Changed commit from e473ebf to 4f7ad67

@fchapoton
Copy link
Contributor

comment:26

any interest on this ? Nicolas ou Florent, ça vous motive un peu ou pas ?

@fchapoton fchapoton modified the milestones: sage-8.2, sage-9.2 Jul 7, 2020
@tscrim
Copy link
Collaborator

tscrim commented Jul 8, 2020

comment:27

I have interest, but no time. :/

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 9, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

23a3548Merge branch 'public/18001' in 9.2.b4
ea4a971replace Returns by Return

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 9, 2020

Changed commit from 4f7ad67 to ea4a971

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Aug 29, 2020
@mkoeppe
Copy link
Member

mkoeppe commented Feb 13, 2021

comment:30

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@fchapoton
Copy link
Contributor

comment:31

or is this just a duplicate of #18265 ?

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 2, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants