-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Too small relative size of axes labels w.r.t. tick marks in 2D plots #18004
Comments
Commit: |
Branch: public/18004 |
comment:1
Attachment: axes_labels.png New commits:
|
comment:2
The attached commit introduces an optional parameter for 2D graphics, |
comment:6
Seems fine on the face of it but I truly have nearly zero Sage reviewing time these days. Wait until school lets out and I'll have a mountain of reviews for you, I'm sure :-) |
comment:7
Hello, If you set
in the class Graphics, why would you need this
Vincent |
Reviewer: Vincent Delecroix |
comment:9
Hi Vincent, You are perfectly right! I am going to change this.
in
in Replying to @videlec:
|
comment:10
Replying to @egourgoulhon:
Sure. Do it at the same time. Vincent |
comment:11
Replying to @videlec:
A systematic search for Eric. |
comment:12
Replying to @egourgoulhon:
Right. The simplest would be to let it as you initially did... sorry. Vincent |
comment:13
Replying to @videlec:
OK.
while in
Shouldn't it be there Eric.
|
comment:14
Replying to @egourgoulhon:
True. But I suggest to not do it here and open a new ticket and get rid of all these try/except. Vincent |
comment:15
Hi, Another point that could be discussed is the default value of the new parameter |
comment:17
Hello Eric, You added two trailing whitespaces! This is very bad. The problem with the right size is that it depends if the label is in math mode (like
I just tried
There is a big difference in the aspects of both letters! What do people use, Vincent |
comment:18
Hi Vincent, Replying to @videlec:
Sorry about this. Yet I've configured my editor to automatically removing trailing whitespaces while saving a file. Apparently two of them went through...
You are right!
Probably it depends, but if you want to have nice labels (in particular labels that coincide with the symbols used in the main text of your article or labels with subscripts or Greek letters), LaTeX seems mandatory. So I would favor the math mode. Maybe lowered to 1.6 as a compromise?... Eric. |
comment:19
Replying to @egourgoulhon:
Looks reasonable to me. Vincent |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:21
Replying to @videlec:
All right; in the new commit, I've set the default value to 1.6. Eric. |
comment:22
Good to go then. Thanks. Vincent |
comment:23
Thanks for the review Vincent! |
Changed branch from public/18004 to |
Changed commit from |
comment:25
See #18421 for followup. |
Consider this plot:
The size of the labels x and y is quite small and barely readable when the figure is reproduced in a article with moderate size (cf. the attached figure).
In the current settings, the only way to enlarge it is via the optional argument fontsize:
But then the tick marks are too large!
One should be able to set separately the size of the axes labels and that of the tick marks.
CC: @videlec @kcrisman
Component: graphics
Keywords: days64
Author: Eric Gourgoulhon
Branch:
69354fc
Reviewer: Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/18004
The text was updated successfully, but these errors were encountered: