Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use alarm() instead of interrupt_after_delay() in doctests #18037

Closed
jdemeyer opened this issue Mar 22, 2015 · 7 comments
Closed

Use alarm() instead of interrupt_after_delay() in doctests #18037

jdemeyer opened this issue Mar 22, 2015 · 7 comments
Labels
p: major / 3 t: enhancement t: tests
Milestone
sage-6.6

Comments

@jdemeyer
Copy link

For a while, interrupt_after_delay() was the recommended way to test interrupts. However, since alarms are also handled the same way by Sage, it's better to use alarm().

I have kept interrupt_after_delay() in ecl.pyx since that tests an ECL handler, which apparently doesn't support SIGALRM.

Component: doctest coverage

Author: Jeroen Demeyer

Branch/Commit: b8ed24a

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/18037
@jdemeyer jdemeyer added this to the sage-6.6 milestone Mar 22, 2015
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/use_alarm___instead_of_interrupt_after_delay___in_doctests

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

New commits:

b8ed24aUse alarm() instead of interrupt_after_delay()

@jdemeyer
Copy link
Author

Commit: b8ed24a

@pjbruin
Copy link
Contributor

pjbruin commented Mar 25, 2015

Reviewer: Peter Bruin

@pjbruin
Copy link
Contributor

pjbruin commented Mar 25, 2015

comment:3

Looks good to me.

@vbraun
Copy link
Member

vbraun commented Apr 14, 2015

Changed branch from u/jdemeyer/use_alarm___instead_of_interrupt_after_delay___in_doctests to b8ed24a

@vbraun vbraun closed this as completed in 4014016 Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: tests
Projects
None yet
Milestone
sage-6.6
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @pjbruin