Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorization.__mul__ assumes that the primes in the factorization commute, which may not be a valid assumption #1804

Closed
williamstein opened this issue Jan 17, 2008 · 4 comments
Closed

Factorization.__mul__ assumes that the primes in the factorization commute, which may not be a valid assumption #1804

williamstein opened this issue Jan 17, 2008 · 4 comments
Labels
c: basic arithmetic p: major / 3 t: bug
Milestone
sage-2.10.1

Comments

@williamstein
Copy link
Contributor

This is LAME:

sage: R.<x,y> = FreeAlgebra(QQ, 2)
sage: F = Factorization([(x,3), (y,2)]); F
x^3 * y^2
sage: F*F
x^6 * y^4

Component: basic arithmetic

Issue created by migration from https://trac.sagemath.org/ticket/1804
@williamstein williamstein added this to the sage-2.10.1 milestone Jan 17, 2008
@williamstein
Copy link
Contributor Author

comment:1

Same comments apply to __invert__ in the file factorization.py.

sage: R.<x,y> = FreeAlgebra(QQ, 2)
sage: F = Factorization([(x,3), (y,2)]); F
x^3 * y^2
sage: F^(-1)
x^-3 * y^-2

@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Jan 20, 2008

comment:2

Attachment: ncalexan-1804.patch.gz

@ncalexan ncalexan mannequin added the s: needs review label Jan 20, 2008
@mwhansen
Copy link
Contributor

comment:3

Looks good to me.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 21, 2008

comment:4

Merged in Sage 2.10.1.alpha1

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jan 21, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: basic arithmetic p: major / 3 t: bug
Projects
None yet
Milestone
sage-2.10.1
Development

No branches or pull requests
2 participants
@mwhansen @williamstein