Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sig_on() from __dealloc__ #18087

Closed
jdemeyer opened this issue Mar 30, 2015 · 5 comments
Closed

Remove sig_on() from __dealloc__ #18087

jdemeyer opened this issue Mar 30, 2015 · 5 comments
Labels
c: cython p: minor / 4 t: enhancement
Milestone
sage-6.6

Comments

@jdemeyer
Copy link

Since __dealloc__ cannot raise exceptions, we should remove sig_on() statements.

Component: cython

Author: Jeroen Demeyer

Branch/Commit: c9dce18

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/18087
@jdemeyer jdemeyer added this to the sage-6.6 milestone Mar 30, 2015
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/remove_sig_on___from___dealloc__

@jdemeyer
Copy link
Author

New commits:

c9dce18Remove sig_on() from __dealloc__

@jdemeyer
Copy link
Author

Commit: c9dce18

@pjbruin
Copy link
Contributor

pjbruin commented Mar 31, 2015

Reviewer: Peter Bruin

@vbraun
Copy link
Member

vbraun commented Apr 9, 2015

Changed branch from u/jdemeyer/remove_sig_on___from___dealloc__ to c9dce18

@vbraun vbraun closed this as completed in b19fad7 Apr 9, 2015
@jdemeyer jdemeyer mentioned this issue Dec 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: cython p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-6.6
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @pjbruin