Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doctest coverage for finite_field_givaro up to 100% #1812

Closed
malb opened this issue Jan 17, 2008 · 3 comments
Closed

doctest coverage for finite_field_givaro up to 100% #1812

malb opened this issue Jan 17, 2008 · 3 comments
Labels
c: documentation p: major / 3 t: bug
Milestone
sage-2.10.1

Comments

@malb
Copy link
Member

malb commented Jan 17, 2008

besides this, this patch also removes the redundant K.is_prime method, sorry for the mess. It can easily be re-added though but this time in FiniteField_generic instead of in every implementation.

Component: documentation

Issue created by migration from https://trac.sagemath.org/ticket/1812
@malb malb added this to the sage-2.10.1 milestone Jan 17, 2008
@malb
Copy link
Member Author

malb commented Jan 17, 2008

Attachment: finite_field_givaro_doctest.patch.gz

@mwhansen
Copy link
Contributor

comment:1

Looks good to me.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 21, 2008

comment:2

Merged in Sage 2.10.1.alpha1

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jan 21, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: major / 3 t: bug
Projects
None yet
Milestone
sage-2.10.1
Development

No branches or pull requests
2 participants
@mwhansen @malb