let Transducer(word) output a word #18123

dkrenn · 2015-04-03T19:21:26Z

Make

sage: W = Words([0,1])
sage: inverter(W([0,1,0]))
word: 101
sage: inverter(words.FibonacciWord([0,1]))
word: 1011010110110101101011011010110110101101...

work.

See also #18118.

Depends on #18118
Depends on #18114
Depends on #15267
Depends on #16133

CC: @videlec @cheuberg @sagetrac-skropf

Component: finite state machines

Keywords: sd66, transducer, words

Author: Daniel Krenn

Branch/Commit: 64ee3e8

Reviewer: Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/18123

The text was updated successfully, but these errors were encountered:

dkrenn · 2015-04-03T19:22:00Z

Dependencies: #18118

dkrenn · 2015-04-06T09:10:07Z

Branch: u/dkrenn/fsm/words

dkrenn · 2015-04-06T09:11:34Z

Author: Daniel Krenn

dkrenn · 2015-04-06T09:11:34Z

Last 10 new commits:

`9bf4d02`	`iter_process_simple: docstring and small renaming of parameter`
`9376b18`	`improved doctests (using words)`
`3d3039b`	`Merge branch 'fsm/iter_process-simple' into fsm/words`
`7d8605e`	`add option automatic_output_type`
`9c09323`	make `__call__` work nicly with infinite words
`d28af2f`	`minor code simplification`
`192671d`	`mention new option in docstring of __call__`
`894eb39`	`docstring __call__: reorganize examples`
`afb0178`	`__call__: examples on words added`
`c6340ac`	`include words-examples in top of file`

dkrenn · 2015-04-06T09:11:34Z

Changed dependencies from #18118 to #18118, #18114, #15267

dkrenn · 2015-04-06T09:11:34Z

Commit: c6340ac

cheuberg · 2015-04-17T11:13:43Z

Work Issues: merge current version of #18114

cheuberg · 2015-04-18T04:11:23Z

Changed branch from u/dkrenn/fsm/words to u/cheuberg/fsm/words

sagetrac-git · 2015-04-18T04:19:04Z

Changed commit from c6340ac to 1d7354f

sagetrac-git · 2015-04-18T04:19:04Z

Branch pushed to git repo; I updated commit sha1. New commits:

`0d4e1da`	`Merge #18114 due to renamed method (commit f209b0fec910bcae1f5998ba6b61c0371433ee34)`
`1d7354f`	`Trac #18123: Adapt to current version of #18114`

cheuberg · 2015-04-18T04:20:41Z

Changed work issues from merge current version of #18114 to none

sagetrac-git · 2015-04-18T05:18:42Z

Changed commit from 1d7354f to b3e699e

sagetrac-git · 2015-04-18T05:18:42Z

Branch pushed to git repo; I updated commit sha1. New commits:

`a6e0fe2`	`Trac #18118: Reviewer Patch: Fix ReST formatting error`
`137cbf9`	`Trac #18118: Reviewer Patch: Add doctest`
`f059bc2`	`Trac #18123: Merge latest version of #18118`
`6819d78`	`Trac #18123: Reviewer patch: show input before computing output in doctests`
`b3e699e`	`Trac #18123: Reviewer Patch: Language and ReST formatting error`

cheuberg · 2015-04-18T05:28:28Z

Reviewer: Clemens Heuberger

cheuberg · 2015-04-18T05:28:28Z

comment:10

IMHO .iter_process should return an iterator in every case. Wouldn't it be cleaner to remove automatic_output from .iter_process alltogether and move this convenience option to .process or even only to the convenience method __call__?

Further comments:

Introductory example: The sentence "Here processing works with iterators in background." is unclear to me.
code of __call__: in the branch if ... input_tape.is_finite() == False:, the check if not 'automatic_output_type' in kwargs seems to be superfluous because it is set before.
__call__: Claims that automatic_output_type is set, but it is not.
documentation of .process: What is the difference in the results of automatic_output_type=False and automatic_output_type=None?
Please include doctests for automatic_output_type.
Code of iter_process: IMHO setting kwargs['format_output'] once and using it once, but then again guarded by if_automatic_output_type is some kind of overkill and also some kind of abuse of that parameter.
For simplicity, I'd prefer to eliminate the possibility automatic_output=None: The magic that format_output is investigated in order to determine automatic_output could as well be moved to __call__. I can hardly imagine a use case of calling .process directly with automatic_output=None.

sagetrac-git · 2015-07-28T11:19:57Z

Branch pushed to git repo; I updated commit sha1. New commits:

`e2fcf3b`	`deprecation warning (#16132) removed`
`0039d7d`	`Transducer.cartesian_product: deprecation warning deleted`
`5f45124`	`removed also deprecated variable`
`4a83285`	`Merge tag '6.8' into fsm/cartesian-product-intersection-no-deprecation`
`24f7b3b`	`Trac #16106: remove further occurrences of FSMOldCodeTransducerCartesianProduct`
`ae13509`	`Trac #16133: Merge #16106`
`6b3172e`	`Trac #16133: Three docstrings: command instead of description`
`1a30b06`	`Trac #16133: remove three further instances of FSMOldProcessOutput`
`8765992`	`Trac #18123: Merge #16133 to resolve conflict`

sagetrac-git · 2015-07-28T11:19:57Z

Changed commit from b3e699e to 8765992

cheuberg · 2015-07-28T11:21:30Z

Changed dependencies from #18118, #18114, #15267 to #18118, #18114, #15267. #16133

sagetrac-git · 2015-09-13T13:14:21Z

Changed commit from 8765992 to c70b19a

sagetrac-git · 2015-09-13T13:14:21Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4bc8bc6`	`add additional examples to show difference between 'simple'-option and not using it`
`f00e904`	`seealso block in _iter_process_simple_`
`a28221b`	`minor simplifiction of code and add a comment explaining resetting of output`
`29a54c3`	`doctests for error conditions and rephrase these errors to get more information when raised`
`7d9e481`	`Trac #18118: Additional doctest`
`3ecc012`	`Trac #18118: Rephrase error message.`
`c70b19a`	`Merge #18118 to resolve merge conflict`

dkrenn · 2015-09-14T10:18:23Z

Changed branch from u/cheuberg/fsm/words to u/dkrenn/fsm/words

dkrenn · 2015-09-14T10:20:42Z

Changed commit from c70b19a to 64ee3e8

dkrenn · 2015-09-14T10:20:42Z

comment:15

Replying to @cheuberg:

IMHO .iter_process should return an iterator in every case. Wouldn't it be cleaner to remove automatic_output from .iter_process alltogether and move this convenience option to .process or even only to the convenience method __call__?

.iter_process returns an iterator, but it can be of any type (depending on input type/class) which supports iterating. Thus did not change it.

Further comments: [...]

All done; see commits.

Last 10 new commits:

`5d59d90`	`adapt code after merge to pass doctests`
`e439bf2`	`Trac #15267: Reviewer patch: Use ZZ(..., base=2)`
`6e47b1d`	`minor rephrase doc: remove one "only"`
`80d8798`	`rename write_in_every_step and rephrase doc`
`7c9a164`	`rephrase/extend doc of process_iterator_class`
`b580917`	`Merge remote-tracking branch 'origin/u/dkrenn/fsm/languages' into fsm/words`
`da369d0`	`#18123 comment 10, bullet 1: sentence deleted.`
`c02c375`	`#18123 comment 10, bullet 2: delete unnecessary check`
`2301c1a`	`Trac #18123 comment 10, bullet 3, 4, 6, 7: remove automatic_output_type=None`
`64ee3e8`	`Trac #18123 comment 10, bullet 5: add additional doctests`

cheuberg · 2015-09-14T15:45:01Z

comment:17

modifications are fine, doctests pass, documentation ok.

vbraun · 2015-09-17T14:22:40Z

Changed dependencies from #18118, #18114, #15267. #16133 to #18118, #18114, #15267, #16133

vbraun · 2015-09-18T13:03:10Z

Changed branch from u/dkrenn/fsm/words to 64ee3e8

dkrenn added this to the sage-6.6 milestone Apr 3, 2015

dkrenn added c: finite state machines labels Apr 3, 2015

This comment has been minimized.

Sign in to view

dkrenn added the s: needs review label Apr 6, 2015

cheuberg added s: needs work and removed s: needs review labels Apr 17, 2015

cheuberg added s: needs review and removed s: needs work labels Apr 18, 2015

cheuberg added s: needs work and removed s: needs review labels Apr 18, 2015

dkrenn added s: needs review and removed s: needs work labels Sep 14, 2015

cheuberg added s: positive review and removed s: needs review labels Sep 14, 2015

cheuberg modified the milestones: sage-6.6, sage-6.9 Sep 14, 2015

vbraun removed the s: positive review label Sep 18, 2015

vbraun closed this as completed in de474e0 Sep 18, 2015

dkrenn mentioned this issue Sep 18, 2015

Finite state machines: some cleanup and code rewriting #18227

Closed

cheuberg mentioned this issue Sep 18, 2015

Automata: Add documentation illustrating the use of automata operations #19207

Closed

dkrenn mentioned this issue Sep 18, 2015

rename automata.word to automata.Word #19210

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

let Transducer(word) output a word #18123

let Transducer(word) output a word #18123

dkrenn commented Apr 3, 2015

dkrenn commented Apr 3, 2015

dkrenn commented Apr 6, 2015

dkrenn commented Apr 6, 2015

dkrenn commented Apr 6, 2015

This comment has been minimized.

dkrenn commented Apr 6, 2015

dkrenn commented Apr 6, 2015

cheuberg commented Apr 17, 2015

cheuberg commented Apr 18, 2015

sagetrac-git mannequin commented Apr 18, 2015

sagetrac-git mannequin commented Apr 18, 2015

cheuberg commented Apr 18, 2015

sagetrac-git mannequin commented Apr 18, 2015

sagetrac-git mannequin commented Apr 18, 2015

cheuberg commented Apr 18, 2015

cheuberg commented Apr 18, 2015

sagetrac-git mannequin commented Jul 28, 2015

sagetrac-git mannequin commented Jul 28, 2015

cheuberg commented Jul 28, 2015

sagetrac-git mannequin commented Sep 13, 2015

sagetrac-git mannequin commented Sep 13, 2015

dkrenn commented Sep 14, 2015

dkrenn commented Sep 14, 2015

dkrenn commented Sep 14, 2015

cheuberg commented Sep 14, 2015

vbraun commented Sep 17, 2015

vbraun commented Sep 18, 2015

let Transducer(word) output a word #18123

let Transducer(word) output a word #18123

Comments

dkrenn commented Apr 3, 2015

dkrenn commented Apr 3, 2015

dkrenn commented Apr 6, 2015

dkrenn commented Apr 6, 2015

dkrenn commented Apr 6, 2015

This comment has been minimized.

dkrenn commented Apr 6, 2015

dkrenn commented Apr 6, 2015

cheuberg commented Apr 17, 2015

cheuberg commented Apr 18, 2015

sagetrac-git mannequin commented Apr 18, 2015

sagetrac-git mannequin commented Apr 18, 2015

cheuberg commented Apr 18, 2015

sagetrac-git mannequin commented Apr 18, 2015

sagetrac-git mannequin commented Apr 18, 2015

cheuberg commented Apr 18, 2015

cheuberg commented Apr 18, 2015

sagetrac-git mannequin commented Jul 28, 2015

sagetrac-git mannequin commented Jul 28, 2015

cheuberg commented Jul 28, 2015

sagetrac-git mannequin commented Sep 13, 2015

sagetrac-git mannequin commented Sep 13, 2015

dkrenn commented Sep 14, 2015

dkrenn commented Sep 14, 2015

dkrenn commented Sep 14, 2015

cheuberg commented Sep 14, 2015

vbraun commented Sep 17, 2015

vbraun commented Sep 18, 2015