Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref: add various missing modules to r/*rings* #18169

Closed
mezzarobba opened this issue Apr 11, 2015 · 23 comments
Closed

Ref: add various missing modules to r/*rings* #18169

mezzarobba opened this issue Apr 11, 2015 · 23 comments

Comments

@mezzarobba
Copy link
Member

Many files in sage/rings/* are not in the documentation!

follow up: #18300

Component: documentation

Author: Marc Mezzarobba

Branch/Commit: 54df1d6

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/18169

@mezzarobba mezzarobba added this to the sage-6.6 milestone Apr 11, 2015
@mezzarobba
Copy link
Member Author

Branch: u/mmezzarobba/ref-rings

@mezzarobba
Copy link
Member Author

New commits:

827913epolynomial_compiled: rst fixes
760a5a1number_field.totallyreal_*: rst fixes
6ffc7d9sage.rings.bern*: rst fixes
9ce70d7Ref: add various missing modules to r/*rings*

@mezzarobba
Copy link
Member Author

Commit: 9ce70d7

@mezzarobba
Copy link
Member Author

Author: Marc Mezzarobba

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

30599c4games.hexad: rst fixes
a3261b8sandpiles.sandpiles: rst fixes
ca7ac34matroids_plot_helpers: rst fixes
087cabcmodform.theta: rst fixes
f736624cunningham_tables: rst fixes
1df5afbmonoids.strings_ops: rst fixes
6858c7fstats.r: rst fixes
558761dRef: remove duplicate entry in r/algebras
2ceb598Ref: add missing modules to various parts of the manual
3491f58Merge branch 'ref-others' into ref-rings

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2015

Changed commit from 9ce70d7 to 3491f58

@mezzarobba
Copy link
Member Author

Dependencies: 18170

@mezzarobba
Copy link
Member Author

Changed dependencies from 18170 to #18170

@mezzarobba
Copy link
Member Author

Changed dependencies from #18170 to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

cf23812polynomial_compiled: rst fixes
f7c0fa2number_field.totallyreal_*: rst fixes
9ed1b17sage.rings.bern*: rst fixes
54df1d6Ref: add various missing modules to r/*rings*

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2015

Changed commit from 3491f58 to 54df1d6

@videlec
Copy link
Contributor

videlec commented Apr 25, 2015

Changed commit from 54df1d6 to d878386

@videlec
Copy link
Contributor

videlec commented Apr 25, 2015

comment:9

Approximately all modules cite Cohen's book. But each of them has its own reference!

In the main index, there is a section Number Theory, Algebraic Geometry. But many modules that you added are in rings (like sage/rings/bernmm, sage/rings/bernoulli_mod_p, sage/rings/contfrac, sage/rings/factorint, sage/rings/fast_arith).

I did some changes and cleaning in number fields. Tell me if you like. I can also try to reorganise the ring section.

Vincent


New commits:

d878386Tiny documentation modifications for number fields

@videlec
Copy link
Contributor

videlec commented Apr 25, 2015

Changed branch from u/mmezzarobba/ref-rings to public/18169

@mezzarobba
Copy link
Member Author

comment:10

I really would prefer to keep these improvements for another ticket, in order to keep the current “add missing modules...” tickets independent of each other. It will be much easier to make changes that span several of them once all modules that need to appear in the reference manual appear somewhere!

@videlec
Copy link
Contributor

videlec commented Apr 25, 2015

Reviewer: Vincent Delecroix

@videlec
Copy link
Contributor

videlec commented Apr 25, 2015

Changed commit from d878386 to 54df1d6

@videlec
Copy link
Contributor

videlec commented Apr 25, 2015

Changed branch from public/18169 to u/mmezzarobba/ref-rings

@videlec
Copy link
Contributor

videlec commented Apr 25, 2015

comment:11

Then it is good to go as the documentation builds! I will open a ticket for number fields with my commit.

@mezzarobba
Copy link
Member Author

comment:12

Replying to @videlec:

Then it is good to go as the documentation builds! I will open a ticket for number fields with my commit.

Thanks! Please Cc: me on the new ticket.

@videlec

This comment has been minimized.

@videlec
Copy link
Contributor

videlec commented Apr 25, 2015

comment:13

I did, for the other readers it is #18300.

@vbraun
Copy link
Member

vbraun commented Apr 26, 2015

Changed branch from u/mmezzarobba/ref-rings to 54df1d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants