Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize base class construction for functorial construction categories #18174

Closed
tscrim opened this issue Apr 12, 2015 · 12 comments
Closed

Generalize base class construction for functorial construction categories #18174

tscrim opened this issue Apr 12, 2015 · 12 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Apr 12, 2015

This ticket implements the following syntactic sugar for functorial
construction categories::

    GradedModules(K)  ->  Modules(K).Graded()
    Modules.Graded(K) ->  Modules(K).Graded()

This makes them behave consistently with CategoryWithAxiom.

As is noted in the code, the internal logic is very similar, but there
seemed at this point to be no good way to avoid the duplication.

The first syntactic sugar was actually already partially implemented
for GradedModulesCategory, so half of the work is just generalizing
existing code.

The syntactic sugar is not valid for construction categories that take
extra arguments like Algebras, since there is no generic way to
decide what the argument should be used for:

    Sets.Algebras(K)  ->   Sets(K).Algebras() or Sets().Algebras(K) ?

CC: @nthiery

Component: categories

Keywords: sd67

Author: Travis Scrimshaw

Branch: c35a270

Reviewer: Nicolas M. Thiéry

Issue created by migration from https://trac.sagemath.org/ticket/18174

@tscrim tscrim added this to the sage-6.6 milestone Apr 12, 2015
@tscrim tscrim self-assigned this Apr 12, 2015
@tscrim
Copy link
Collaborator Author

tscrim commented Apr 12, 2015

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 12, 2015

New commits:

0e78e25Implement generic functorial construction base class magic.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 12, 2015

Commit: 0e78e25

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 12, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

160416218174: small doc improvements
c35a27018174: more doc improvements + uniformization with CategoryWithAxiom

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 12, 2015

Changed commit from 0e78e25 to c35a270

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 12, 2015

comment:3

LGTM

@nthiery
Copy link
Contributor

nthiery commented Apr 12, 2015

comment:4

For the record: all long tests pass up to some failures/timeouts I often get on my test machine:

sage -t --long src/sage/misc/cachefunc.pyx  # 1 doctest failed
sage -t --long src/sage/tests/cmdline.py  # 1 doctest failed
sage -t --long src/sage/dev/sagedev.py  # Timed out
sage -t --long src/sage/schemes/elliptic_curves/lseries_ell.py  # Timed out
sage -t --long src/sage/modular/arithgroup/arithgroup_perm.py  # Timed out
sage -t --long src/doc/en/tutorial/interfaces.rst  # 10 doctests failed

@nthiery

This comment has been minimized.

@nthiery
Copy link
Contributor

nthiery commented Apr 13, 2015

Changed keywords from none to sd67

@vbraun
Copy link
Member

vbraun commented Apr 15, 2015

Changed branch from public/categories/functorial_magic-18174 to c35a270

@kcrisman
Copy link
Member

Changed commit from c35a270 to none

@kcrisman
Copy link
Member

Changed reviewer from Nicolas Thiéry to Nicolas M. Thiéry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants