New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show animation #18176
Comments
Author: Volker Braun |
This comment has been minimized.
This comment has been minimized.
Branch: u/vbraun/show_animation |
New commits:
|
Commit: |
comment:4
Blocker? Anyway, were the optional arguments previously broken, had no one tested with the optional tag, or was this a recent change? Andrey's email suggests recent... |
comment:5
The code is only tested with |
comment:6
And I don't have a particular preference for whether to make it a blocker or not. If somebody cares about animations then they can always review this ticket before sage-6.6 is out (i.e. very soon) |
comment:8
Given that Andrey may not have had a chance to respond about this yet, I'm moving it to blocker until either I get a chance to review it (though all seems straightforward) or he can say it's not that high. |
comment:9
I don't know when it got broken - I was thinking I should check how animations work in SageMathCell with my recent changes and discovered they don't work at all in Sage. The real problem is that they were not even tested. And my concern with changes on this ticket is that it will break But if it is up to me to decide, this is not a blocker. |
comment:10
I tried to preserve the delay parameter, but then I don't even know what its supposed to mean. Sometimes its the numerator of some fraction (with a separate |
comment:11
What exactly do you mean by “its all broken”? It would be kind of nice if the problem report were to report the problem, before suggesting a fix… In any case, I'm on 6.6.beta1 here, using the Sage notebook, and with imagemagick 6.9.0.3 installed on my system. And animations with delay and iterations do work for me. To be more specific,
So what exactly is broken? |
comment:12
Replying to @vbraun:
The doc says correctly:
This is used throughout the public Animation class. You might argue that it's a suboptimal choice, but it's what the GIF spec uses, what most animated GIF editors use, and what Sage has been using so far.
That's in the APngAssembler I wrote, and it's there that way because I consider the APngAssembler a low-level interface, and the low level spec of APNG uses that representation for rational numbers. I saw no reason to complicate things further by introducing my own translation layer, and I didn't consider
For movies, yes. For animated GIFs, in my experience no. I wouldn't mind having |
comment:13
I notice that |
comment:14
Replying to @gagern:
By the same line of argument I suggest we replace seconds everywhere with jiffies, since this is what the kernel developers use. If you go to the movies, whats the frame delay in centiseconds? How many frames per second? ;-) What is broken:
|
comment:15
And I do have imagemagick installed, the tests are just not run by default (See also #13540) |
comment:16
When was the last time you had a Sage-generated movie play at a cinema in your parts? On a more serious note, I believe that
Test coverage is tricky. Since we don't bundle imagemagick, we can't rely on |
comment:17
Test coverage should be easy since PIL(low) can be used to write animated GIF, we just don't use it. In any case, not every optional argument for every potential image file format needs to be exposed via |
comment:18
Animations will be totally broken in Sage-6.6 since apparently that is preferable to not supporting some optional keyword argument. Propose to close this as wontfix until we can rewrite the animations so that no keyword is left behind. |
comment:19
I don't have any objection (well, not enough to break animations) to this temp fix, I just don't have time to properly do a review. As I say,
so please let's make animations still work. Or at least, animation |
comment:20
Actually, I will just make time. |
comment:22
Okay, this is weird. I get it working in the command line now, but
when running tests. In fact, I get this error while doctesting whether or not I apply this! Command
|
comment:23
I know, the tests with enabling optional stuff are generally broken. |
comment:24
Oh, duh! I have to do |
comment:25
Give me another hour - I have to run an time-constrained errand right now but will return to this shortly. |
Changed branch from u/vbraun/show_animation to u/gagern/t/17783/animationSaveKwds |
Changed author from Volker Braun to Martin von Gagern |
comment:27
Here is a branch which preserves the functionality of keyword arguments to New commits:
|
Reviewer: Volker Braun |
Changed branch from u/gagern/t/17783/animationSaveKwds to |
Changed commit from |
comment:30
Wow, you pick up your kid, and the world keeps rotating ;-) Nice!!! |
comment:31
|
comment:32
Replying to @vbraun:
It can? A quick search of the web returned several posts where people talked about animated GIF read support, or the absence of write support, or asked about write support and got no answer. If you are certain about this, and perhaps even know an address with some documentation, could you open a ticket for this?
We had that discussion in #7298 comment:50 and following, and I still disagree. Let's continue this aspect in this thread on the sage-devel list, so we can get more opinons on this. |
Changed branch from |
Changed branch from u/gagern/14dd2818961df94bafdc2e2d1f2b640d3a68d5ae to u/gagern/t/17783/animationSaveKwds |
Commit: |
comment:35
Just forgot to use New commits:
|
Changed branch from u/gagern/t/17783/animationSaveKwds to |
Bandaid until we can implement a proper fix at #17783
CC: @novoselt @gagern
Component: graphics
Author: Martin von Gagern
Branch/Commit:
9a48ae0
Reviewer: Volker Braun
Issue created by migration from https://trac.sagemath.org/ticket/18176
The text was updated successfully, but these errors were encountered: