Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make centrality_betweenness interruptible #18262

Closed
nathanncohen mannequin opened this issue Apr 20, 2015 · 6 comments
Closed

Make centrality_betweenness interruptible #18262

nathanncohen mannequin opened this issue Apr 20, 2015 · 6 comments
Labels
c: graph theory p: major / 3 t: enhancement
Milestone
sage-6.7

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 20, 2015

Make centrality_betweenness interruptible. This is achieved with a try/finally.

Depends on #18260

CC: @dcoudert @sagetrac-borassi

Component: graph theory

Author: Nathann Cohen

Branch/Commit: d665ec7

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/18262
@nathanncohen nathanncohen mannequin added this to the sage-6.7 milestone Apr 20, 2015
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Apr 20, 2015

Commit: d665ec7

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Apr 20, 2015

New commits:

e25a95etrac #18260: Small fix for directed graphs
b83d828trac #18260: Move centrality functions from graph.py to generic_graph.py
e55042etrac #18260: A new doctest
7314459trac #18260: Broken link in the doc
4bc0de8trac #18260: Reviewer's comments
487b3a2trac #18262: regroup mallocs
960fdaatrac #18262: increase identation (and nothing else)
a8c0159trac #18262: Exception check
d665ec7trac #18262: Simplify memory allocation

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Apr 20, 2015

Branch: public/18262

@nathanncohen nathanncohen mannequin added the s: needs review label Apr 20, 2015
@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@dcoudert
Copy link
Contributor

comment:2

Good. I like the check_malloc and sig_check methods. I will learn to use them.

All test pass, so it's good for me.

@vbraun
Copy link
Member

vbraun commented Apr 21, 2015

Changed branch from public/18262 to d665ec7

@vbraun vbraun closed this as completed in 9ea870e Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.7
Development

No branches or pull requests
2 participants
@vbraun @dcoudert