Don't cimport type

[jdemeyer]

This line in src/sage/ext/stdsage.pxd

from cpython.type cimport type

causes trouble as it causes Cython to no longer optimize the type type.

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 459908c

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/18321

[jdemeyer]

Branch: u/jdemeyer/don_t_cimport_type

[jdemeyer]

New commits:

5d4b11e

Don't cimport "type"

[jdemeyer]

Commit: 5d4b11e

[pjbruin]

comment:3

What is the reason for still doing cimport type as pytype in stdsage.pxd? Removing this line (and using type instead of pytype in PY_NEW) does not seem to cause any problems at first sight. Does it have any speed and/or type safety effects?

[pjbruin]

Reviewer: Peter Bruin

[sagetrac-git]

Changed commit from 5d4b11e to 459908c

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

459908c

Use plain "type", not "cpython.type.type" for PY_NEW()

[jdemeyer]

comment:5

Replying to @pjbruin:

What is the reason for still doing cimport type as pytype in stdsage.pxd?

No idea. It must have been needed at some point, but maybe some Cython upgrade changed this?

[pjbruin]

comment:6

Replying to @jdemeyer:

Replying to @pjbruin:

What is the reason for still doing cimport type as pytype in stdsage.pxd?

No idea. It must have been needed at some point, but maybe some Cython upgrade changed this?

Who knows. The other occurrence (in classcall_metaclass.pyx) does seem to be necessary; without it, there is a doctest that crashes Sage due to insufficient type checking.

[vbraun]

Changed branch from u/jdemeyer/don_t_cimport_type to 459908c