Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot3d and parametric_plot3d can be very slow on some inputs #1833

Closed
williamstein opened this issue Jan 18, 2008 · 4 comments
Closed

plot3d and parametric_plot3d can be very slow on some inputs #1833

williamstein opened this issue Jan 18, 2008 · 4 comments

Comments

@williamstein
Copy link
Contributor

sage: x,y = var('x,y')
sage: plot3d(x*y, (x,-1,1), (y,-1,1))

is fast, but

sage: x,y = var('x,y')
sage: plot3d(x*y, (-1,1), (-1,1))

is shockingly slow (and similar remarks for parametric plots). The attached patch fixes this problem.

This also fixes trac #1737.

Component: graphics

Issue created by migration from https://trac.sagemath.org/ticket/1833

@williamstein
Copy link
Contributor Author

comment:2

This patch also moves plot3d_adaptive into plot3d (i.e., as an option), and deprecates globally exposing plot3d_adaptive. This is natural to do in the context of this patch.

@williamstein
Copy link
Contributor Author

Attachment: trac-1833.patch.gz

@mwhansen
Copy link
Contributor

comment:3

Looks good to me.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 21, 2008

comment:4

Merged in Sage 2.10.1.alpha1

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jan 21, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants