Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in dimension of total ideals. #18374

Closed
miguelmarco opened this issue May 6, 2015 · 9 comments
Closed

Inconsistency in dimension of total ideals. #18374

miguelmarco opened this issue May 6, 2015 · 9 comments
Labels
c: algebra p: major / 3 t: bug
Milestone
sage-6.7

Comments

@miguelmarco
Copy link
Contributor

As mentioned in this sage-devel thread, there is an inconsistency in the dimension of total ideals.

Singular returns -1 for the rings it handles, whereas our fallback implementation returns 0.

CC: @sagetrac-jakobkroeker

Component: algebra

Author: Miguel Marco

Branch/Commit: b8051ee

Reviewer: Grayson Jorgenson

Issue created by migration from https://trac.sagemath.org/ticket/18374
@miguelmarco miguelmarco added this to the sage-6.7 milestone May 6, 2015
@miguelmarco
Copy link
Contributor Author

Branch: bugdimension

@miguelmarco
Copy link
Contributor Author

Changed branch from bugdimension to u/mmarco/bugdimension

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 6, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

b8051eeAdded the case dimension=-1 for total ideals over rings not handled by Singular.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 6, 2015

Commit: b8051ee

@sagetrac-gjorgenson
Copy link
Mannequin

sagetrac-gjorgenson mannequin commented May 18, 2015

comment:4

Hi, this simplifies some of the functionality in a ticket I have been working on. Is this ticket ready for review?

@miguelmarco
Copy link
Contributor Author

comment:5

Yes, it should be ready for review.

@sagetrac-gjorgenson
Copy link
Mannequin

sagetrac-gjorgenson mannequin commented May 19, 2015

Reviewer: Grayson Jorgenson

@sagetrac-gjorgenson
Copy link
Mannequin

sagetrac-gjorgenson mannequin commented May 19, 2015

comment:6

Correct dimension is now returned and everything seems to be working properly.

@vbraun
Copy link
Member

vbraun commented May 20, 2015

Changed branch from u/mmarco/bugdimension to b8051ee

@vbraun vbraun closed this as completed in 35858a8 May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.7
Development

No branches or pull requests
2 participants
@vbraun @miguelmarco