Optimize ManinSymbol

[jdemeyer]

Instead of storing the tuple (i,u,v) as a tuple, it would be a lot better and simpler to store it as 3 different attributes.

We also fix comparison to use _cmp_ (which is required for extension types) instead of __cmp__.

Component: cython

Author: Jeroen Demeyer

Branch/Commit: d70023e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/18388

[jdemeyer]

Branch: u/jdemeyer/fix_comparison_for_maninsymbol

[jdemeyer]

Commit: 07ad588

[jdemeyer]

New commits:

07ad588

Optimize ManinSymbol class

[tscrim]

comment:5

Very minor point, but you could do the alignment:

-       return self.__class__(self.parent(),
-                             (self.i,
-                              matrix[0]*self.u + matrix[2]*self.v,
-                              matrix[1]*self.u + matrix[3]*self.v))
+       return type(self)(self.parent(),
+                         (self.i,
+                          matrix[0]*self.u + matrix[2]*self.v,
+                          matrix[1]*self.u + matrix[3]*self.v))

After that, you can set a positive review on my behalf.

[tscrim]

Reviewer: Travis Scrimshaw

[sagetrac-git]

Changed commit from 07ad588 to d70023e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

d70023e

Fix indentation (PEP 8)

[vbraun]

Changed branch from u/jdemeyer/fix_comparison_for_maninsymbol to d70023e