Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix times in graphics doc #18406

Closed
kcrisman opened this issue May 12, 2015 · 10 comments
Closed

Fix times in graphics doc #18406

kcrisman opened this issue May 12, 2015 · 10 comments

Comments

@kcrisman
Copy link
Member

The docstring for show is raw (r""" ... """)
and contains

`[0,1]\\times[0,1]`

which does not render right in the
show documentation.

In a raw string, \\times becomes \\ (newline) + times.

The fix is to use \times instead of \\times.

CC: @kcrisman @slel

Component: documentation

Author: Samuel Lelièvre

Branch/Commit: f259041

Reviewer: Karl-Dieter Crisman

Issue created by migration from https://trac.sagemath.org/ticket/18406

@kcrisman kcrisman added this to the sage-6.7 milestone May 12, 2015
@slel
Copy link
Member

slel commented Nov 21, 2020

comment:1

Here is a fix. Please review.


New commits:

f259041t-18406: Unescape backslash in raw docstring of Graphics

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Nov 21, 2020

Commit: f259041

@slel
Copy link
Member

slel commented Nov 21, 2020

Author: Samuel Lelièvre

@slel
Copy link
Member

slel commented Nov 21, 2020

Branch: public/18406

@slel slel modified the milestones: sage-6.7, sage-9.3 Nov 21, 2020
@kcrisman
Copy link
Member Author

comment:4

I think I just reported this without even looking at the code - that would surely do it. Shall I trust that you verified in both html and pdf?

@slel
Copy link
Member

slel commented Nov 22, 2020

comment:5

Ran make and make doc-pdf successfully.

Checked both html and pdf; that instance of
[0,1]\times[0,1] now renders fine in both.

Found no other similar problem needing fixing.

@kcrisman
Copy link
Member Author

comment:6

Thanks for this!

@kcrisman
Copy link
Member Author

Reviewer: Karl-Dieter Crisman

@vbraun
Copy link
Member

vbraun commented Dec 13, 2020

Changed branch from public/18406 to f259041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants