New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniformize truncated multiplication for polynomials #18420
Comments
This comment has been minimized.
This comment has been minimized.
Branch: u/vdelecroix/18420 |
New commits:
|
Commit: |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:5
rebased on 6-7.rc0 |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
Why did you add the comment in |
comment:12
Because this has nothing to do in It is a good idea to introduce special rule for multiplication by constants. But this should be done globally. I will make the comment clearer. Vincent |
comment:13
All right, I can just get rid of the declaration in the pxd file and everything is fine. Let me do it. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Mario Pernici |
Changed branch from u/vdelecroix/18420 to |
The operation
_mul_trunc
on polynomials is currently only implemented in specialized classes with custom declaration. We define a global one in Polynomial with signature(and deprecate the former _mul_trunc).
We also add specialized implentation for integer polynomials (relying on
fmpz_poly_mullow
) and rational polynomials (relying onfmpq_poly_mullow
).Such method would be really helpful for multiplication of power series.
Component: algebra
Author: Vincent Delecroix
Branch/Commit:
063516e
Reviewer: Mario Pernici
Issue created by migration from https://trac.sagemath.org/ticket/18420
The text was updated successfully, but these errors were encountered: