Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade 4ti2 package to version 1.6.5 #18459

Closed
mkoeppe opened this issue May 19, 2015 · 17 comments
Closed

Upgrade 4ti2 package to version 1.6.5 #18459

mkoeppe opened this issue May 19, 2015 · 17 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented May 19, 2015

4ti2 version 1.6.5 was just ​released.

Just released a new version of the mathematical software 4ti2. Version 1.6.5 is a minor update, which improves error checking while reading zsolve input files.

It also corrects a mistake in the test-suite introduced in version 1.6.3 released last month, which is included in Sage at the moment and which might scare some users. (There was no actual bug.)

The manual has been updated to include a reference to commands and their options and a reference to the C API. All commands now support --help; and long options are now available on Mac OS X.

Should update the package to get these improvements; the updated manual may make it easier to support 4ti2's features in Sage (#18325) or perhaps to develop a library-based interface to 4ti2.

(Updated: This ticket was for update to 1.6.4; but I had to release another version, 1.6.5, which actually compiles with the gcc version that Sage uses.)

Download the 4ti2 tarfile from ​http://www.4ti2.de/version_1.6.5/4ti2-1.6.5.tar.gz to
SAGEROOT/upstream, checkout the git branch and do sage -f 4ti2 to try the new package.

CC: @dimpase

Component: packages: optional

Author: Matthias Koeppe

Branch: da53185

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/18459

@mkoeppe mkoeppe added this to the sage-6.8 milestone May 19, 2015
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Upgrade 4ti2 package to version 1.6.4 Upgrade 4ti2 package to version 1.6.5 May 20, 2015
@mkoeppe
Copy link
Member Author

mkoeppe commented May 20, 2015

@mkoeppe
Copy link
Member Author

mkoeppe commented May 20, 2015

New commits:

8d60aa0Update 4ti2 spkg scripts to version 1.6.5, add spkg-check

@mkoeppe
Copy link
Member Author

mkoeppe commented May 20, 2015

Commit: 8d60aa0

@dimpase
Copy link
Member

dimpase commented May 20, 2015

comment:4

well, shouldn't it be Matthias, not Dima:

[[[
+=== 4ti2-1.6.5 (Dima Pasechnik, May 19, 2015) ===
}}}

@dimpase
Copy link
Member

dimpase commented May 20, 2015

Author: Matthias Koeppe

@dimpase
Copy link
Member

dimpase commented May 20, 2015

Changed commit from 8d60aa0 to da53185

@dimpase
Copy link
Member

dimpase commented May 20, 2015

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented May 20, 2015

Changed branch from u/mkoeppe/upgrade_4ti2_package_to_version_1_6_4 to public/18459

@dimpase
Copy link
Member

dimpase commented May 20, 2015

New commits:

8d60aa0Update 4ti2 spkg scripts to version 1.6.5, add spkg-check
da53185fix the author's name

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented May 20, 2015

comment:6

HMmmmmm.. If I make no mistake we dropped the "changelog" section of SPKG.txt when we switched to new-style packages. This, because the changelog is part of Sage's git tree.

Nathann

@dimpase
Copy link
Member

dimpase commented May 20, 2015

comment:7

Replying to @nathanncohen:

HMmmmmm.. If I make no mistake we dropped the "changelog" section of SPKG.txt when we switched to new-style packages. This, because the changelog is part of Sage's git tree.

IMHO one needs to specify what should be in the "main" commit message on such a ticket (do you often do multi-line commit messages?), otherwise this is not a sufficient replacement for SPKG.txt...

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented May 20, 2015

comment:8

IMHO one needs to specify what should be in the "main" commit message on such a ticket (do you often do multi-line commit messages?), otherwise this is not a sufficient replacement for SPKG.txt...

I do not see any reason why packages should be handled differently from the rest of Sage's source code. How can you defend a SPKG.txt file for packages, and regular git logs for everything else?

Regardless of that, I am only telling you that the standard now is apparently to strip changelogs. So expect it to happen in the future, if somebody eventually touches this package.

Nathann

@vbraun
Copy link
Member

vbraun commented May 20, 2015

Changed branch from public/18459 to da53185

@jdemeyer
Copy link

jdemeyer commented Jun 6, 2015

Changed commit from da53185 to none

@jdemeyer
Copy link

jdemeyer commented Jun 6, 2015

comment:10

FYI: doctests don't pass, so the package was moved to experimental.

@dimpase
Copy link
Member

dimpase commented Jun 6, 2015

comment:11

Replying to @jdemeyer:

FYI: doctests don't pass, so the package was moved to experimental.

Jeroen, wat is aan de hand, since when are you allowed to override collective decisions of making a package optional?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants