Broken (optional) doctests with bliss

[nathanncohen]

I still fail to see how we missed that in #17464 O_o

Nathann

CC: @jdemeyer @sagetrac-azi

Component: graph theory

Author: Nathann Cohen

Branch/Commit: db9c4fc

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/18460

[nathanncohen]

Branch: public/18460

[sagetrac-git]

Commit: 71a8ccb

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

71a8ccb

trac #18460: Broken (optional) doctests with bliss

[sagetrac-git]

Changed commit from 71a8ccb to db9c4fc

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

db9c4fc

trac #18460: Broken (optional) doctests with bliss

[dcoudert]

comment:4

The patch ipasses all tests on bliss.pyx and generic_graph.py, before and after installing bliss.
Should I do something special to ensure that optional tests are executed?

Why are you removing isomorphism test with bliss?

[nathanncohen]

comment:5

The patch ipasses all tests on bliss.pyx and generic_graph.py, before and after installing bliss.
Should I do something special to ensure that optional tests are executed?

The option is "--optional=sage,bliss"

Why are you removing isomorphism test with bliss?

Well, because there is no is_isomophic function in the 'bliss' module. There use to be one, in th preliminary phases of the branch that added support for bliss, but it was never available in a release.

Nathann

[dcoudert]

Reviewer: David Coudert

[dcoudert]

comment:6

For me the patch is good to go (install, test, doc, etc.).

One remark: it could be good practice to indicate in the ticket the optional parameters to do the tests.

[nathanncohen]

comment:7

One remark: it could be good practice to indicate in the ticket the optional parameters to do the tests.

In the ticket? Why O_o

It's all in the developer's manual O_o

Nathann

[vbraun]

Changed branch from public/18460 to db9c4fc