Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nice print method for Sha(Elliptic curve) #1847

Closed
williamstein opened this issue Jan 19, 2008 · 4 comments
Closed

add nice print method for Sha(Elliptic curve) #1847

williamstein opened this issue Jan 19, 2008 · 4 comments
Assignees
@williamstein
Labels
c: number theory p: major / 3 t: bug
Milestone
sage-3.3

Comments

@williamstein
Copy link
Contributor

Printing of Sha is ugly:

sage: E = EllipticCurve('37a')
sage: Sha = E.sha(); Sha
<class 'sage.schemes.elliptic_curves.sha.Sha'>

Component: number theory

Issue created by migration from https://trac.sagemath.org/ticket/1847
@williamstein williamstein added this to the sage-3.4.1 milestone Jan 19, 2008
@williamstein williamstein self-assigned this Jan 19, 2008
@rlmill rlmill mannequin added the s: needs review label Jan 23, 2009
@aghitza
Copy link

aghitza commented Jan 23, 2009

comment:2

Looks good.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 25, 2009

comment:3

This patch causes the following doctest failure:

mabshoff@geom:/scratch/mabshoff/sage-3.3.alpha3$ ./sage -t  devel/sage/sage/schemes/elliptic_curves/ell_rational_field.py
sage -t  "devel/sage/sage/schemes/elliptic_curves/ell_rational_field.py"
**********************************************************************
File "/scratch/mabshoff/sage-3.3.alpha3/devel/sage/sage/schemes/elliptic_curves/ell_rational_field.py", line 3639:
    sage: S
Expected:
    <class 'sage.schemes.elliptic_curves.sha_tate.Sha'>
Got:
    Shafarevich-Tate group for the Elliptic Curve defined by y^2 + y = x^3 - x over Rational Field
**********************************************************************

I guess the obvious fix is to change the doctest.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title add nice print method for Sha(Elliptic curve) [trivial to implement -- requires taste] [needs doctest fix] add nice print method for Sha(Elliptic curve) Jan 25, 2009
@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 26, 2009

comment:4

Attachment: trac-1847.patch.gz

Patch updated.

@rlmill rlmill mannequin changed the title [needs doctest fix] add nice print method for Sha(Elliptic curve) add nice print method for Sha(Elliptic curve) Jan 26, 2009
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 28, 2009

comment:5

Merged in Sage 3.3.alpha3

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jan 28, 2009
@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-3.4.1, sage-3.3 Jan 28, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamstein williamstein

Labels
c: number theory p: major / 3 t: bug
Projects
None yet
Milestone
sage-3.3
Development

No branches or pull requests
2 participants
@aghitza @williamstein