Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some cleanup in symbolic/ #18476

Closed
fchapoton opened this issue May 22, 2015 · 13 comments
Closed

some cleanup in symbolic/ #18476

fchapoton opened this issue May 22, 2015 · 13 comments
Labels
c: symbolics p: minor / 4 t: enhancement
Milestone
sage-6.8

Comments

@fchapoton
Copy link
Contributor

  • put raise statements into python3 syntax
  • correct some problems found by pyflakes
    in the symbolic/ directory

Component: symbolics

Author: Frédéric Chapoton

Branch/Commit: 330a9a8

Reviewer: André Apitzsch

Issue created by migration from https://trac.sagemath.org/ticket/18476
@fchapoton fchapoton added this to the sage-6.8 milestone May 22, 2015
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/18476

@fchapoton
Copy link
Contributor Author

New commits:

8cc789espring cleanup of symbolic/ : py3 raise syntax and pyflakes found errors

@fchapoton

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor Author

Commit: 8cc789e

@a-andre
Copy link

a-andre commented May 23, 2015

comment:2

In src/sage/symbolic/assumptions.py although it's a comment you should write except TypeError as mess because mess is used in the if-condition or better remove the comment out lines.

The remaining looks good to me.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 23, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

1c08dcdMerge branch 'u/chapoton/18476' into 6.8.b0
128d3ebtrac #18476 remove 3 commented lines

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 23, 2015

Changed commit from 8cc789e to 128d3eb

@fchapoton
Copy link
Contributor Author

comment:4

done

@a-andre
Copy link

a-andre commented May 23, 2015

Reviewer: André Apitzsch

@vbraun
Copy link
Member

vbraun commented May 23, 2015

comment:6

Documentation doesn't build

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 24, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

330a9a8trac #18476 remove brun function

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 24, 2015

Changed commit from 128d3eb to 330a9a8

@vbraun
Copy link
Member

vbraun commented May 25, 2015

Changed branch from u/chapoton/18476 to 330a9a8

@vbraun vbraun closed this as completed in 5f94203 May 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: symbolics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-6.8
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @a-andre